Skip to content

Invalid default value for UspNatV1Field.MSPA_COVERED_TRANSACTION? #29

Description

@matt-martin

The specification says that the valid values for MspaCoveredTransaction are:

1 Yes
2 No

But this field is given a default value of 0 here:

fields.put(UspNatV1Field.MSPA_COVERED_TRANSACTION, new EncodableFixedInteger(2, 0));

Should the spec be updated to say that 0 is valid? Or would it make sense to use a different default in the code?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions