Repository navigation
fix: preserve resource accounting on rejected allocations - #838
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resource preemption could reject an affordable request after deleting another agent’s reservation. With a budget of 100 and 60 reserved, a higher-priority request for 70 needs 30 more; the allocator previously tried to free the full 70. Requests that could not fit all dimensions also removed reservations before failing. Plan victims against the remaining deficits and apply the plan only when every dimension fits.
Reject negative requirements without changing the ledger, reject negative budget maxima at construction, and report finite zero utilization for zero-capacity budgets. Existing null-budget behavior and run-scoped ownership remain intact. Rollback on rejection, invalid-budget rejection, and the zero-utilization convention are explicit integrator policies added by this repair, not prior documented guarantees or owner decisions. Preemption remains reservation bookkeeping and does not stop arbitrary agent code.
Validation: