fix: Thumbnail fallback and multiple thumbnail using dicom tag browser - #340
Merged
Conversation
|
Here's the code health analysis summary for commits Analysis Summary
|
|
6 tasks
igoroctaviano
added a commit
that referenced
this pull request
Aug 11, 2026
* fix: size slide-list overview previews from container and matrix Compute OverviewImageViewer resizeFactor from preview tile dimensions and TotalPixelMatrix size so THUMBNAIL/OVERVIEW extent matches the rendered PNG. Restores fit after #340 removed the fixed 0.3 thumbnail heuristic (#399). * fix: use integer DICOMweb viewport sizes for overview previews Google Healthcare rejects fractional viewport=w,h (HTTP 400). Derive resizeFactor so cols*factor and rows*factor are integers; fall back to factor 1 when no integer downscale fits the slide-list tile. * Fix overview map * fix: size overview mini-map symmetrically for wide and tall slides Prefer a shared viewport fraction on both axes and cap growth at 60% so wide slides no longer spill to full width while tall slides get matching height treatment. * fix: keep full-slide overview after clamp and zoom Retarget DMV's locked overview resolution in place after Slim resizes the mini-map, re-pinning the slide center so OverviewMap resetExtent cannot crop the view when zooming. * fix: equalize overview overlay insets and keep map above memory footer Put MemoryFooter in an AppShell column below the viewer, size the mini-map with an OL-style fixed box, and keep overlay left/bottom insets aligned without the collapse control adding layout chrome. * fix: keep debug count badges on the bug button corner Mirror antd Badge layout (line-height: 1 + translate(50%, -50%)) so AppShell overflow no longer crops pills pinned by the header line-height.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fix: Duplicate Thumbnail Images in DICOM Tag Browser
Problem
Thumbnail scale was wrong
After commit 89a62a4, thumbnail images were appearing twice in the DICOM tag browser.
Root Cause
When thumbnail image support was added:
thumbnailImagesand
volumeImagesarrays (since they share ImageType VOLUME/THUMBNAIL behavior)Solution
Remove
thumbnailImagesfrom the Slide constructor concatenation.THUMBNAIL images are already included in
volumeImagessince they:Changes
Result
Thumbnail images now appear only once in the DICOM tag browser while
maintaining their proper relationship with the volume image pyramid.
Ref: #337 (comment)