Skip to content

chore: bump to 0.0.36 - #108

Merged
Fermionic-Lyu merged 1 commit into
mainfrom
chore/bump-0.0.36
Aug 19, 2026
Merged

chore: bump to 0.0.36#108
Fermionic-Lyu merged 1 commit into
mainfrom
chore/bump-0.0.36

Conversation

@Fermionic-Lyu

@Fermionic-Lyu Fermionic-Lyu commented Aug 19, 2026

Copy link
Copy Markdown
Member

Release cut for #106insta deploy <dir> now works against a local insta-oss daemon (501 from the token mint → local docker build). No other changes since 0.0.35.

🤖 Generated with Claude Code


Summary by cubic

Bumps insta to 0.0.36 to support local source deploys against insta-oss. Previously insta deploy <dir> attempted a token mint and failed with 501; now local deploys use a local docker build, meeting the requirement from issue #106.

  • Only package.json and package-lock.json version fields changed; no code diffs.
  • Validate insta deploy <dir> with a running insta-oss daemon to confirm local build path.
  • No migration required.

Written for commit c3c6aa4. Summary will update on new commits.

Review in cubic

@Fermionic-Lyu
Fermionic-Lyu enabled auto-merge (squash) August 19, 2026 18:55

@jwfing jwfing left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: chore: bump to 0.0.36

Summary: A clean, correct version bump from 0.0.35 → 0.0.36 across package.json and package-lock.json; the only substantive note is that the PR description understates what this release actually ships.

Requirements context

No docs/superpowers/ or docs/specs/ content exists in this repo, so no matching spec/plan was found — assessed against the PR body, the git history since v0.0.35, and the repo's version-release conventions. This PR is the "bump the version field before tagging" step that version-release expects to be merged to main before a release is cut.

Verification performed

  • Version consistency: package.json (package.json:3) and package-lock.json (both the root version and the packages."" entry) are all 0.0.36. No source file hardcodes a version — the CLI resolves it dynamically at runtime from package.json (src/index.ts:55, src/commands/feedback.ts:75, src/observe/install.ts:11), so no stale constant is left behind. The bump is complete.
  • Tag idempotency: existing tags stop at v0.0.35; no v0.0.36 tag/release exists, so the follow-up tag release is safe (avoids the irreversible npm-publish collision the version-release skill warns about).
  • Feature actually present: #106's feat(deploy) commit (fcd8678) is on main and reachable from head, so the 0.0.36 release genuinely contains the local docker build fallback it references.

Findings

Critical

(none) — the version bump is correct, consistent, and collision-free; nothing blocks merge.

Suggestion

  • Functionality / accuracy of release scope — The body states "No other changes since 0.0.35" and cubic's summary frames this purely as the #106 release. That's not accurate: git log v0.0.35..HEAD shows this release bundles five feature PRs, not one:

    • #100 — MySQL/MongoDB service commands
    • #103 — canonical secret-binding commands
    • #104insta build pre-push verification
    • #105insta compute exec
    • #106 — local source deploys (docker build fallback)

    Blast radius is low because the actual GitHub release notes are auto-generated at tag time (generate_release_notes: true), so the published changelog will be correct regardless. But the PR description is what a human reviewer reads to decide whether the release is safe to cut, and #103/#105/#100 are non-trivial user-facing surface. Recommend updating the description to list the full set of PRs shipping in 0.0.36 so the reviewer isn't approving a narrower change than what actually ships.

Information

  • Commit-message convention — This bump commit is chore: bump to 0.0.36, whereas prior release bumps consistently use chore(release): 0.0.XX (#NN) (97b0f4e, 2d49db0, 9d4b3c9, …). Cosmetic only; harmless, but aligning keeps git log --grep on release commits uniform.

Software engineering / Security / Performance

  • Software engineering: No tests are expected or needed for a pure version-field bump; this matches every prior release PR in the repo.
  • Security: No security-relevant changes — no code, dependency, or lockfile-dependency changes (only the two version strings in the lockfile moved).
  • Performance: No performance-relevant changes.

Verdict

approved (informational — no Critical findings; posted as a comment, human approval via the normal flow). The bump is correct and ready to tag; the only ask is a description update to reflect the full 0.0.36 scope, which is non-blocking.

@jwfing jwfing left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - approved.

@Fermionic-Lyu
Fermionic-Lyu merged commit 9e68cdd into main Aug 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants