chore(release): 0.0.34 - #99
Merged
Merged
Conversation
Fermionic-Lyu
enabled auto-merge (squash)
August 18, 2026 20:58
jwfing
reviewed
Aug 18, 2026
jwfing
left a comment
Member
There was a problem hiding this comment.
Review — chore(release): 0.0.34
Summary: A clean, self-consistent patch version bump (0.0.33 → 0.0.34) across package.json and package-lock.json, releasing the already-merged insta feedback work; no functional code changes.
Requirements context: No matching spec/plan found — insta-cli keeps specs under docs/specs/ and this is a release chore with no spec. Assessed against the PR description and the repo's release workflow (.github/workflows/release.yml).
Verification performed
- Version consistency: Both
package.json:3andpackage-lock.json(rootversionand thepackages[""]entry) move0.0.33→0.0.34. Keeping the lockfile in lockstep matters here — thepublish-npmjob runsnpm ci, which fails on a package/lock version mismatch. ✅ - Correct next version: Prior release was
0.0.33(merge #94,9d4b3c9);0.0.34is the correct next patch. ✅ - Shipped work is actually present: The three PRs cited in the body are all merged into the base (
a9055ea):#95(feat: insta feedback),#96(review follow-ups),#98(--fileregular-files-only). ✅ - No other version references to update — no
CHANGELOG, andgrepfinds no other hardcoded0.0.33/0.0.34strings in the tree. ✅ - Release path matches the body: pushing tag
v0.0.34triggersrelease.yml→ Bun builds binaries →publish-npmpublishesinstato npm. Tag has no hyphen, so it correctly takes thelatestdist-tag / GitHub "Latest" release (production channel). ✅
Findings
Critical: (none)
Suggestion: (none)
Information
- Software engineering — No tests accompany this change, which is correct: a version-string bump has no behavior to test, and CI's
npm ciimplicitly validates package/lock consistency. - Process note (out of scope, pre-existing) — The PR body says npm is published "via OIDC", which the
publish-npmjob indeed does (id-token: write,--provenance, trusted publishing, no token). However, therelease.ymlcomment block still describes a "GRANULAR AUTOMATION token (repo secretNPM_TOKEN)" for the npm half. That comment is stale relative to the OIDC flow directly below it and could confuse a release operator — worth a cleanup in a separate PR, but nothing to change here.
Dimension coverage
- Software engineering: No conventions violated; no tests warranted for a version bump.
- Functionality: Bump is correct, complete, and keeps
npm cigreen. - Security: No security-relevant changes — no new dependencies, no code, no secrets.
- Performance: No performance-relevant changes.
Verdict
approved — no Critical findings. Textbook clean release bump; safe to tag v0.0.34 after merge. (Informational only; the green-checkmark approval remains a separate human action.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version bump for the release shipping
insta feedback(#95 + review follow-ups #96, #98).After merge: tag
v0.0.34→ release workflow builds binaries + publishes npm via OIDC.🤖 Generated with Claude Code
Summary by cubic
Releases
instav0.0.34 to ship the new feedback flow. v0.0.33 shipped without feedback; v0.0.34 enables it with no other behavior changes.v0.0.34after merge; the release workflow builds binaries and publishes tonpmvia OIDC.Written for commit 8c37c08. Summary will update on new commits.