Skip to content

feat: feedback posts to feedback.instacloud.com - #101

Merged
Fermionic-Lyu merged 1 commit into
mainfrom
feat/feedback-domain
Aug 18, 2026
Merged

Fermionic-Lyu merged 1 commit into
mainfrom
feat/feedback-domain

Conversation

@Fermionic-Lyu

@Fermionic-Lyu Fermionic-Lyu commented Aug 18, 2026 •

Copy link
Copy Markdown
Member

Default FEEDBACK_ENDPOINT moves from the app-named compute host to the custom domain feedback.instacloud.com (DNS: insta-cloud#77, cert issued, ingest verified live — bad-enum probe returns the self-teaching 400). Old URL keeps working for released clients; INSTA_FEEDBACK_URL still overrides.

Companion: insta-mcp same change. Release 0.0.35 follows once merged.

🤖 Generated with Claude Code


Summary by cubic

Switches the default feedback POST endpoint from https://insta-main-api-cdad9b6c.compute.instacloud.com/v1/feedback to https://feedback.instacloud.com/v1/feedback to provide a stable domain. Existing clients keep working and INSTA_FEEDBACK_URL still overrides.

Review and rollout

Written for commit f63b5b6. Summary will update on new commits.

Review in cubic

Custom domain (infra/dns.tf via insta-cloud#77) replaces the app-named
compute host as the default endpoint — stable if the service is ever
renamed. Old URL keeps working; INSTA_FEEDBACK_URL still overrides.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@Fermionic-Lyu
Fermionic-Lyu enabled auto-merge (squash) August 18, 2026 22:26

@jwfing jwfing left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: feat: feedback posts to feedback.instacloud.com

Summary: A one-line change swapping the default FEEDBACK_ENDPOINT from the app-named Fly compute host to the stable custom domain feedback.instacloud.com, leaving the INSTA_FEEDBACK_URL override and the public ingest token untouched.

Requirements context: No /docs/superpowers/ or docs/specs/ spec exists in this repo, and nothing under docs/ matches this PR — assessing against the PR description alone (and the companion insta-mcp change it references).

Findings

Critical — (none)

Suggestion — (none)

Information

  • Functionality (verified live). Confirmed the new default endpoint independently, not just from the PR body: feedback.instacloud.com resolves (CNAME → insta-main-api-cdad9b6c.fly.dev, i.e. the same Fly app the old ...compute.instacloud.com host fronted), the TLS chain validates (ssl_verify_result=0), and a bad-enum probe POST to /v1/feedback returns the self-teaching 400 described in the PR body. Because DNS points at the same backing app, the "old URL keeps working for released clients" claim holds — this is a pure hostname change, not a backend move. src/commands/feedback.ts:40-42
  • Software engineering. No test change is needed and none is expected: test/feedback.test.ts injects a fetchImpl and asserts on payload/behavior, never on the URL constant (test/feedback.test.ts:15-21, 109+), so the endpoint is not pinned by any assertion and the suite stays green. Consistent with the file's existing "hardcoded, env-overridable" convention (src/commands/feedback.ts:35-43).
  • Security. No new attack surface. The ingest token remains the public-by-design insta-feedback-public-v1 (documented at src/commands/feedback.ts:35-39; real abuse control is server-side per-IP rate-limit + weekly dedup), no secrets are added or logged, and the request stays HTTPS with a validated certificate. If anything this is a marginal improvement — a purpose-named domain decouples the client default from an opaque Fly app slug, easing future emergency rotation.
  • Performance. No performance-relevant change (same single 10s-timeout, zero-retry POST).

Verdict

approved (informational — a human still applies the GitHub approval). Single-line, well-scoped, and independently verified against the live endpoint; no blocking concerns. Reminder from the PR body: cut release 0.0.35 and land the companion insta-mcp change so both clients point at the new default together.

@jwfing jwfing left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - approved.

@Fermionic-Lyu
Fermionic-Lyu merged commit 788d980 into main Aug 18, 2026
2 checks passed
Fermionic-Lyu added a commit that referenced this pull request Aug 18, 2026
Ships the feedback.instacloud.com default endpoint (#101).

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants