Skip to content

Devel - #7

Merged
jwfing merged 2 commits into
mainfrom
devel
Jul 4, 2026
Merged

jwfing merged 2 commits into
mainfrom
devel

Conversation

@jwfing

@jwfing jwfing commented Jul 4, 2026 •

Copy link
Copy Markdown
Member

Summary by cubic

Adds insta secrets set and insta secrets unset for managing user secrets, and fixes flag parsing so options like --branch bind to subcommands. Enables project-wide or per-branch secret updates, with values from args or stdin.

  • New Features

    • Add insta secrets set <name> [value] [--branch] and insta secrets unset <name> [--branch]; values can come from stdin; project-wide by default; --branch scopes to one branch; both handle approval responses.
    • Update policy set help to include secrets.write.
  • Bug Fixes

    • Enable positional options so flags after a subcommand (e.g., --branch) apply to that subcommand instead of the parent command group.

Written for commit a535e25. Summary will update on new commits.

Review in cubic

jwfing added 2 commits July 3, 2026 16:11
Add `insta secrets set <name> [value] [--branch]` and `secrets unset <name>
[--branch]`, project-wide by default; value comes from the argument or stdin
(keeps secrets out of shell history). Both are handleApproval-aware (202).
Extend `policy set`'s help text with the secrets.write action.

Also fix a latent commander bug that silently dropped `--branch`/`--org` when
passed to a subcommand whose parent group (secrets, billing) declares the
same flag name for its own default action — enable positional options so a
flag written after the subcommand name binds to the subcommand, not the
group.

@Fermionic-Lyu Fermionic-Lyu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Approved.

@jwfing
jwfing merged commit 47bffff into main Jul 4, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants