Repository navigation
Conversation
No longer present.
Code extracted from:
https://github.com/malaterre/GDCM.git
at commit dacccb6c04ee13f6958359c193f804358f4672d7 (release).
* upstream-GDCM: GDCM 2026-03-10 (dacccb6c)
|
Too many files changed for review. ( |
|
One concern I have is when this branch in merged into release and then main. The main branch can be merged with "ours" stragegy to ensure that the changes here don't effect release/main. However, the gdcm sub-tree will have different commits it's unclear to me how best to manage this. @bradking Any advice on how to manage the sub-tree for updated to a release branch? |
|
The |
|
That seems like regular issue with the release-5.4 not being merged into release and main branches |
hjmjohnson
left a comment
hjmjohnson
left a comment
There was a problem hiding this comment.
I have no problems with this approach. A careful merge into upstream/main might be needed, but that should not be hard to accomplish.
|
We are queuing a number of patches on |
|
@thewtex You are likely the one to do the next steps, so I'll let you merge this. |
f9a2e13
into
InsightSoftwareConsortium:release-5.4
…e-5.4-update-gdcm Release 5.4 update gdcm
…e-5.4-update-gdcm Release 5.4 update gdcm
Add GDCM support for modern CMAKE_*_OUTPUT_DIRECTORY variables. Removes setting legacy CMake cache variables. Internlly GDCM still uses the legacy names. Backport to release-5.4: only the src/CMakeLists.txt wrapper hunk is applied. The src/gdcm/CMakeLists.txt portion of the original commit already landed on release-5.4 via the GDCM upstream update (PR #6059), so its compatibility shim was emitting deprecation warnings because the wrapper kept setting EXECUTABLE_OUTPUT_PATH / LIBRARY_OUTPUT_PATH. Removing those set() calls fixes the CMake deprecation warnings reported in issue #6551. (cherry picked from commit d5cf8de) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Updating GDCM to the current
releasebranch on ITKrelease-5.4.