[agourakis82]

Reject absolute ITK_INSTALL_*_DIR values at configure time so install metadata cannot be generated with prefixed absolute paths. Closes #6896.

Validation

• cmake -S . -B build-6896-policy-ok -DITK_BUILD_DEFAULT_MODULES=OFF -DBUILD_TESTING=OFF -DBUILD_EXAMPLES=OFF
• cmake -S . -B build-6896-policy-bad -DITK_BUILD_DEFAULT_MODULES=OFF -DBUILD_TESTING=OFF -DBUILD_EXAMPLES=OFF -DITK_INSTALL_LIBRARY_DIR=/usr/lib64 failed with the new configure-time error
• cmake -S . -B build-6896-cmake-install-libdir-bad -DITK_BUILD_DEFAULT_MODULES=OFF -DBUILD_TESTING=OFF -DBUILD_EXAMPLES=OFF -DCMAKE_INSTALL_LIBDIR=/usr/lib64 failed with the new configure-time error
• cmake --build build-6896-policy-ok --target itkTestDriver -j 6
• git diff --check
• pre-commit run --files CMakeLists.txt CMake/ITKModuleExternal.cmake Modules/Core/TestKernel/src/CMakeLists.txt

AI assistance

• Role: implementation and local validation support for a maintainer-directed CMake policy change.
• The diff, commit, and validation were reviewed before submission.

[dzenanz]

@greptileai review this

[dzenanz]

Looks good on a glance.

[greptile-apps]

Confidence Score: 5/5

[Medium risk] Build system adds validation for installation directory paths.

The PR appears safe to merge; no actionable issue remains from the changes reviewed.

Summary

The PR moves absolute install-directory rejection to the two ITK configuration entry points and removes the redundant TestKernel-local check.

• Both entry points validate the seven ITK_INSTALL_*_DIR values after assigning defaults.
• TestKernel continues to calculate its install RPATH for configurations that pass validation.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[In-tree ITK configure] --> C[Assign install-directory defaults]
  B[External module configure] --> C
  C --> D{Any ITK install directory absolute?}
  D -- Yes --> E[Stop configuration]
  D -- No --> F[Generate install metadata and process modules]

Loading

_{Reviews (2) · Last reviewed commit: "BUG: Reject absolute ITK install directo..."}

[Copilot]

Copilot review overview

🟢 Approval recommended

The validation is consistently applied before affected install paths are generated, with no unresolved issues found.

Review effort: Balanced
Findings: None

What changed in this PR

Rejects absolute ITK installation directories before generating invalid install metadata.

Changes:

• Validates all ITK_INSTALL_*_DIR values in main and external-module configurations.
• Simplifies test-driver RPATH generation under the enforced relative-path invariant.

File	Description
CMakeLists.txt	Adds top-level install-directory validation.
CMake/​ITKModuleExternal.cmake	Applies validation to external modules.
Modules/​Core/​TestKernel/​src/​CMakeLists.txt	Removes redundant local validation.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.