Repository navigation
ENH: Address Greptile findings on GDCM series direction tests - #6940
Merged
hjmjohnson merged 3 commits intoOct 13, 2026
Merged
hjmjohnson merged 3 commits into
hjmjohnson merged 3 commits into
Conversation
CreateGoogleTestDriver labeled only the driver executable, so tests found by gtest_discover_tests were skipped by ctest -L <Module>. Pass the module label through to the discovered tests.
Setting the target DEPENDS property does not order the build. Use add_dependencies so ReadSlicesReverseOrder finds its DICOM input when only the driver is built.
github-actions
Bot
added
type:Infrastructure
hjmjohnson
marked this pull request as ready for review
October 9, 2026 14:04
This comment was marked as resolved.
This comment was marked as resolved.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
hjmjohnson
force-pushed
the
test-gdcm-series-direction-followups
branch
from
October 9, 2026 14:59
517fb45 to
e9324aa
Compare
blowekamp
approved these changes
Oct 9, 2026
N-Dekker
reviewed
Oct 11, 2026
N-Dekker
reviewed
Oct 11, 2026
The oblique and randomized cases built frames from two angles, which always gave a slice normal of (0, -sin b, cos b). Compose three rotations so the normal has three nonzero components.
hjmjohnson
force-pushed
the
test-gdcm-series-direction-followups
branch
from
October 13, 2026 11:49
e9324aa to
6285a50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #5357: addresses three Greptile findings raised against its backport (#6930) so the improvements land in main first.
ctest -L ITKIOGDCMincludes the 17GDCMSeriesDirectiontests.ITKDatais a real build prerequisite ofITKGDCMImageIOGTestDriver.Local validation
ITKGDCMImageIOGTestDriver; 33/33 ofGDCMSeriesDirection,ITKGDCMImageIO,GDCMSeriesFileNamespassed.ctest -N -L ITKIOGDCMlists all 17GDCMSeriesDirectiontests (0 before).pre-commit run --all-filesexits 0.CreateGoogleTestDriver, so every module's discovered GoogleTests gain their module label. The cross-compilegtest_add_testspath is unchanged._STRING/TOSTRINGmacros are deliberately not renamed: the idiom is local to.cxxtests and already used in 17 files.AI assistance
Claude Code (claude-sonnet-5-5) drafted the changes; built and tested locally and reviewed before pushing.