Repository navigation
Conversation
|
The Linux Python failure looks unrelated to this change: Gaussian smoothing passes, and the only failure among 185 tests is the median filter’s type-hint check ( |
dzenanz
left a comment
There was a problem hiding this comment.
Mostly looks good. I have not taken such a good look at tests besides ShortAxesAndRepeatedUpdates.
| } | ||
|
|
||
| ImageType::Pointer | ||
| SmoothEligibleAxes(const ImageType * input, const FilterType::SigmaArrayType & sigma) |
There was a problem hiding this comment.
This largely duplicates filter's functionality. Whenever the filter is updated, this needs to be updated too. I would prefer a simpler test, with some simple-to-reason-about constants. If we want to make sure that the filter's output does not drift, we should add a new image regression baseline with the expected output. That is better/easier to do via classic test, as opposed to GTest.
Allow singleton slices to retain smoothing along their longer axes. Recursive gradient filtering remains a separate follow-up. Closes InsightSoftwareConsortium#6997
79d8d43 to
2605ef9
Compare
|
Rebase only: onto current upstream/main. The conflict was in RegistrationMethodsv4/test/CMakeLists.txt; the new ShortDimensions GTest now sits in the same list as the SyN GTest, with one driver call. Build and the short-axis and Smoothing GTests pass locally. |
Hi! This lets
SmoothingRecursiveGaussianImageFilterskip axes shorter than four pixels while smoothing the remaining axes, including singleton slices used in registration. Closes #6997.Scope and local testing
Local checks on Linux:
SmoothingRecursiveGaussianImageFilter#6997 unchanged. Bothsigma=1.0andsigma=0.0recovered the expected 4-pixel X translation.PR Checklist
PR Checklist
No public API additions or new wrapped classes. The class documentation describes the short-axis behavior; both new test files have the standard license header. No separate examples contribution is needed for this enhancement.
AI assistance
AI assistance contributed to diagnosis, implementation, and regression tests. Focused C++ and Python checks passed locally.