Skip to content

ENH: Assert Cuberille mesh counts now that issue #6301 is fixed - #7031

Merged
dzenanz merged 1 commit into
InsightSoftwareConsortium:mainfrom
dzenanz:cuberilleCounts
Oct 29, 2026
Merged

dzenanz merged 1 commit into
InsightSoftwareConsortium:mainfrom
dzenanz:cuberilleCounts

Conversation

@dzenanz

@dzenanz dzenanz commented Oct 28, 2026

Copy link
Copy Markdown
Member

Pin the expected point/cell counts in the tibial and prostate Cuberille tests, now stable after the #6301 fix (3d5d889), and drop prostate_00's RUN_SERIAL workaround.

Test results

Counts were identical across 10 runs per dataset (MSVC 2022 Release), for both QuadEdgeMesh and itk::Mesh:

Test Points Cells
tibial_cartilage_cropped_0.1 526 938
tibial_cartilage_cropped_0.5 387 682
prostate_00 10184 20266

All 52 Cuberille tests pass under ctest -j8 (3 runs). With 3d5d889 reverted, the pinned tests failed in 5/5 runs (tibial_0.5 every time, tibial_0.1 4/5). prostate_00 takes ~0.5 s, so RUNS_LONG/RUN_SERIAL are no longer needed.

AI assistance

🤖 Generated with Claude Code

@github-actions github-actions Bot added type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Enhancement Improvement of existing methods or implementation area:Filtering Issues affecting the Filtering module labels Oct 28, 2026
@dzenanz
dzenanz marked this pull request as ready for review October 28, 2026 20:25
@greptile-apps

greptile-apps Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This PR appears safe to merge.

Summary

Adds expected point and cell counts to three Cuberille tests after the upstream fix.

  • Three Cuberille tests now check their mesh point and cell counts.
  • The prostate Cuberille test can run alongside other tests.

No actionable issues found. Tests were not run during this review.

Reviews (1) · Last reviewed commit: "ENH: Assert Cuberille mesh counts now th..." · Reviewed by Greptile

@hjmjohnson

Copy link
Copy Markdown
Member

@dzenanz the ARMBUILD failure here is the itkIndent.h include cycle fixed by #7028 (now on main). This branch does not allow maintainer edits, so could you rebase it on main?

…rtium#6301 is fixed

The tibial_cartilage_cropped and prostate_00 tests passed 0 for the
expected point and cell counts because the out-of-bounds read fixed in
3d5d889 made them nondeterministic. Pin the now-stable counts so a
regression of that fix fails these tests. Drop the RUN_SERIAL and
RUNS_LONG workaround on prostate_00, which was for the same crash.
@dzenanz
dzenanz merged commit 2e353bf into InsightSoftwareConsortium:main Oct 29, 2026
19 checks passed
@dzenanz
dzenanz deleted the cuberilleCounts branch October 29, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Filtering Issues affecting the Filtering module type:Enhancement Improvement of existing methods or implementation type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants