Repository navigation
ENH: Assert Cuberille mesh counts now that issue #6301 is fixed - #7031
Merged
Merged
Conversation
dzenanz
marked this pull request as ready for review
October 28, 2026 20:25
Contributor
[Low impact] This PR appears safe to merge.
|
hjmjohnson
approved these changes
Oct 29, 2026
Member
…rtium#6301 is fixed The tibial_cartilage_cropped and prostate_00 tests passed 0 for the expected point and cell counts because the out-of-bounds read fixed in 3d5d889 made them nondeterministic. Pin the now-stable counts so a regression of that fix fails these tests. Drop the RUN_SERIAL and RUNS_LONG workaround on prostate_00, which was for the same crash.
dzenanz
force-pushed
the
cuberilleCounts
branch
from
October 29, 2026 01:01
0d90a2b to
1c6f912
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin the expected point/cell counts in the tibial and prostate Cuberille tests, now stable after the #6301 fix (3d5d889), and drop prostate_00's RUN_SERIAL workaround.
Test results
Counts were identical across 10 runs per dataset (MSVC 2022 Release), for both
QuadEdgeMeshanditk::Mesh:tibial_cartilage_cropped_0.1tibial_cartilage_cropped_0.5prostate_00All 52 Cuberille tests pass under
ctest -j8(3 runs). With 3d5d889 reverted, the pinned tests failed in 5/5 runs (tibial_0.5every time,tibial_0.14/5).prostate_00takes ~0.5 s, soRUNS_LONG/RUN_SERIALare no longer needed.AI assistance
🤖 Generated with Claude Code