Skip to content

Update NumPy patching#170

Merged
ndgrigorian merged 11 commits into
mainfrom
update-umath-patching
Mar 18, 2026
Merged

Update NumPy patching#170
ndgrigorian merged 11 commits into
mainfrom
update-umath-patching

Conversation

@ndgrigorian

@ndgrigorian ndgrigorian commented Mar 10, 2026

Copy link
Copy Markdown
Collaborator

This PR

  • Adds safety checks to patching
  • Add warnings related to multi-threaded programs
  • Implement _GlobalPatch wrapper class which implements patching globally
  • Rename _patch module to _patch_numpy
  • Rename patching functions
  • Aligns with mkl_fft and mkl_random patching interfaces

@ndgrigorian
ndgrigorian force-pushed the update-umath-patching branch 4 times, most recently from c05279b to 1a4529a Compare March 10, 2026 04:19
@ndgrigorian
ndgrigorian marked this pull request as ready for review March 10, 2026 04:33
@ndgrigorian

ndgrigorian commented Mar 10, 2026

Copy link
Copy Markdown
Collaborator Author

@antonwolfy @jharlow-intel
the patch update here is ready for review

@ndgrigorian
ndgrigorian force-pushed the update-umath-patching branch from 1a4529a to e40ef5a Compare March 10, 2026 05:11
antonwolfy
antonwolfy reviewed Mar 10, 2026
View reviewed changes
Comment thread mkl_umath/src/_patch_numpy.pyx
Comment thread mkl_umath/src/_patch_numpy.pyx
Comment thread mkl_umath/__init__.py
antonwolfy
antonwolfy reviewed Mar 10, 2026
View reviewed changes
Comment thread mkl_umath/src/_patch_numpy.pyx Outdated
Comment thread mkl_umath/src/_patch_numpy.pyx Outdated
Comment thread mkl_umath/tests/test_basic.py Outdated
jharlow-intel
jharlow-intel reviewed Mar 10, 2026
View reviewed changes
Comment thread mkl_umath/src/_patch_numpy.pyx
antonwolfy
antonwolfy reviewed Mar 10, 2026
View reviewed changes
Comment thread mkl_umath/__init__.py
@ndgrigorian
ndgrigorian force-pushed the update-umath-patching branch from a6a0c96 to 711df0e Compare March 10, 2026 16:15
@ndgrigorian

ndgrigorian commented Mar 11, 2026

Copy link
Copy Markdown
Collaborator Author

@jharlow-intel @antonwolfy
quick note, after adjusting the tests, I now see the segfault resolved in #171 locally

applying the fix did resolve it locally, as well

@ndgrigorian
ndgrigorian force-pushed the update-umath-patching branch 2 times, most recently from 11e83a8 to 7f0887f Compare March 11, 2026 23:56
antonwolfy
antonwolfy reviewed Mar 14, 2026
View reviewed changes
Comment thread mkl_umath/tests/test_patching.py
Comment thread mkl_umath/src/_patch_numpy.pyx Outdated
Comment thread mkl_umath/src/_patch_numpy.pyx Outdated
@ndgrigorian
ndgrigorian requested a review from antonwolfy March 16, 2026 22:23
@ndgrigorian
ndgrigorian force-pushed the update-umath-patching branch from 5fe8e80 to fca09ef Compare March 17, 2026 20:20
@ndgrigorian
Update umath patching
7a82440 
* Add safety checks to patching
* Add warnings related to multi-threaded programs
* Implement _GlobalPatch wrapper class which implements patching globally
* Rename _patch module to _patch_numpy
* Rename patching functions
@ndgrigorian
address review comments
bcb62f7
@ndgrigorian
add deprecated patching aliases to __init__.py
8d1dc9e
@ndgrigorian
pre-commit fix
0ef0e87
@ndgrigorian
improve patch safety when failing to patch or restore numpy functions
558ee9d
@ndgrigorian
factor patching tests into separate file
d06a76c
@ndgrigorian
fix docstrings in patching
b592e02
@ndgrigorian
ndgrigorian force-pushed the update-umath-patching branch from fca09ef to ad5aa63 Compare March 17, 2026 20:30
antonwolfy
antonwolfy previously approved these changes Mar 18, 2026
View reviewed changes

@antonwolfy antonwolfy left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ndgrigorian, no more comments from me.
The only thing left is to add an entry to the changelog.

@antonwolfy antonwolfy added this to the 0.4.0 release milestone Mar 18, 2026
ndgrigorian added a commit that referenced this pull request Mar 18, 2026
@ndgrigorian
add gh-170 and gh-171 to changelog
7014346
@ndgrigorian
ndgrigorian force-pushed the update-umath-patching branch from 7014346 to 2bf9af3 Compare March 18, 2026 20:34
@ndgrigorian
ndgrigorian requested a review from antonwolfy March 18, 2026 20:34
antonwolfy
antonwolfy approved these changes Mar 18, 2026
View reviewed changes

@antonwolfy antonwolfy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ndgrigorian

@ndgrigorian
ndgrigorian merged commit f109abf into main Mar 18, 2026
86 of 89 checks passed
@ndgrigorian
ndgrigorian deleted the update-umath-patching branch March 18, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes
@xaleryb xaleryb Awaiting requested review from xaleryb xaleryb is a code owner
@jharlow-intel jharlow-intel Awaiting requested review from jharlow-intel jharlow-intel is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.4.0 release

Development

Successfully merging this pull request may close these issues.

3 participants

@ndgrigorian @antonwolfy @jharlow-intel