Skip to content

Dev networks - DO NOT MERGE - #1688

Draft
jpraynaud wants to merge 5 commits into
mainfrom
jpraynaud/1687-optimize-cardano-tx-proof
Draft

jpraynaud wants to merge 5 commits into
mainfrom
jpraynaud/1687-optimize-cardano-tx-proof

Conversation

@jpraynaud

@jpraynaud jpraynaud commented May 16, 2024 •

Copy link
Copy Markdown
Member

Important

This PR is for tests only and must not be merged

@jpraynaud jpraynaud added the prototype 🛠️ Prototype/PoC of a feature label May 16, 2024
@jpraynaud jpraynaud self-assigned this May 16, 2024
@github-actions

github-actions Bot commented May 16, 2024 •

Copy link
Copy Markdown

Test Results

     5 files  ± 0     221 suites  ±0   1h 17m 19s ⏱️ - 19m 13s
 3 720 tests  - 14   3 720 ✅  - 14  0 💤 ±0  0 ❌ ±0 
11 936 runs   - 14  11 936 ✅  - 14  0 💤 ±0  0 ❌ ±0 

Results for commit e473177. ± Comparison against base commit e92707c.

This pull request removes 17 and adds 3 tests. Note that renamed tests count towards both.
mithril-stm ‑ circuits::halo2_ivc::tests::encoding::negative::slow::circuit_rejects_preimage_inconsistent_with_the_message
mithril-stm ‑ circuits::halo2_ivc::tests::encoding::negative::slow::circuit_rejects_wrong_current_epoch_byte_range
mithril-stm ‑ circuits::halo2_ivc::tests::encoding::negative::slow::circuit_rejects_wrong_next_merkle_tree_commitment_byte_range
mithril-stm ‑ circuits::halo2_ivc::tests::encoding::negative::slow::circuit_rejects_wrong_next_protocol_parameters_byte_range
mithril-stm ‑ circuits::halo2_ivc::tests::golden::golden_verification_key_test::slow::golden_recursive_modification_test
mithril-stm ‑ circuits::halo2_ivc::tests::golden::positive::slow::genesis_base_case_circuit_is_accepted
mithril-stm ‑ circuits::halo2_ivc::tests::golden::positive::slow::replay_integrity_matches_stored_next_step_output
mithril-stm ‑ circuits::halo2_ivc::tests::in_circuit::accumulator::slow::circuit_rejects_tampered_same_epoch_accumulator_public_inputs
mithril-stm ‑ circuits::halo2_ivc::tests::in_circuit::genesis_gating::slow::genesis_step_accepts_garbage_certificate_proof_bytes
mithril-stm ‑ circuits::halo2_ivc::tests::in_circuit::genesis_gating::slow::genesis_step_accepts_garbage_ivc_proof_bytes
…
mithril-stm ‑ proof_system::halo2_ivc_snark::proof::tests::slow::prove_bootstrap_produces_first_epoch_proof_and_rolling_state
mithril-stm ‑ proof_system::halo2_ivc_snark::proof::tests::slow::prove_same_epoch_produces_proof_without_rolling_state
mithril-stm ‑ protocol::aggregate_signature::clerk::tests::ivc_aggregation_logs_the_duration_of_each_step

♻️ This comment has been updated with latest results.

@jpraynaud
jpraynaud temporarily deployed to testing-preview May 16, 2024 16:38 — with GitHub Actions Inactive
@jpraynaud
jpraynaud temporarily deployed to testing-sanchonet May 16, 2024 16:38 — with GitHub Actions Inactive
@jpraynaud
jpraynaud force-pushed the jpraynaud/1687-optimize-cardano-tx-proof branch from 2ed9469 to 0f5a44a Compare May 17, 2024 11:28
@jpraynaud
jpraynaud temporarily deployed to testing-preview May 17, 2024 11:35 — with GitHub Actions Inactive
@jpraynaud
jpraynaud temporarily deployed to testing-sanchonet May 17, 2024 11:35 — with GitHub Actions Inactive
@jpraynaud
jpraynaud temporarily deployed to testing-mainnet May 17, 2024 13:03 — with GitHub Actions Inactive
@jpraynaud
jpraynaud force-pushed the jpraynaud/1687-optimize-cardano-tx-proof branch 3 times, most recently from 41ed35b to e0f47e1 Compare May 21, 2024 18:52
@jpraynaud
jpraynaud temporarily deployed to testing-preview May 21, 2024 19:00 — with GitHub Actions Inactive
@jpraynaud
jpraynaud temporarily deployed to testing-sanchonet May 21, 2024 19:00 — with GitHub Actions Inactive
@jpraynaud
jpraynaud force-pushed the jpraynaud/1687-optimize-cardano-tx-proof branch from e0f47e1 to 1cd5b3a Compare May 22, 2024 07:31
@jpraynaud
jpraynaud temporarily deployed to testing-preview May 22, 2024 07:38 — with GitHub Actions Inactive
@jpraynaud
jpraynaud temporarily deployed to testing-sanchonet May 22, 2024 07:38 — with GitHub Actions Inactive
@jpraynaud
jpraynaud temporarily deployed to testing-mainnet May 22, 2024 10:29 — with GitHub Actions Inactive
@jpraynaud
jpraynaud force-pushed the jpraynaud/1687-optimize-cardano-tx-proof branch 4 times, most recently from a0e498c to 039003e Compare May 23, 2024 08:12
@jpraynaud
jpraynaud temporarily deployed to testing-preview May 23, 2024 08:20 — with GitHub Actions Inactive
@jpraynaud
jpraynaud temporarily deployed to testing-sanchonet May 23, 2024 08:20 — with GitHub Actions Inactive
@jpraynaud
jpraynaud force-pushed the jpraynaud/1687-optimize-cardano-tx-proof branch from 039003e to fecabad Compare May 23, 2024 08:49
@jpraynaud
jpraynaud temporarily deployed to testing-preview May 23, 2024 08:56 — with GitHub Actions Inactive
@jpraynaud
jpraynaud temporarily deployed to testing-sanchonet May 23, 2024 08:56 — with GitHub Actions Inactive
@jpraynaud
jpraynaud force-pushed the jpraynaud/1687-optimize-cardano-tx-proof branch from fecabad to df9737a Compare May 23, 2024 09:58
@jpraynaud
jpraynaud temporarily deployed to testing-sanchonet May 24, 2024 15:01 — with GitHub Actions Inactive
@jpraynaud
jpraynaud temporarily deployed to testing-preview May 24, 2024 15:20 — with GitHub Actions Inactive
@jpraynaud
jpraynaud temporarily deployed to testing-sanchonet May 24, 2024 15:20 — with GitHub Actions Inactive
@jpraynaud
jpraynaud temporarily deployed to testing-mainnet May 24, 2024 15:49 — with GitHub Actions Inactive
@jpraynaud
jpraynaud force-pushed the jpraynaud/1687-optimize-cardano-tx-proof branch 2 times, most recently from c8df10f to 4066c06 Compare May 30, 2024 14:22
@jpraynaud
jpraynaud temporarily deployed to testing-preview May 30, 2024 14:31 — with GitHub Actions Inactive
@jpraynaud
jpraynaud temporarily deployed to testing-sanchonet May 30, 2024 14:31 — with GitHub Actions Inactive
@jpraynaud
jpraynaud temporarily deployed to testing-mainnet May 30, 2024 15:08 — with GitHub Actions Inactive
@jpraynaud
jpraynaud force-pushed the jpraynaud/1687-optimize-cardano-tx-proof branch from 4066c06 to 11e53c5 Compare June 5, 2024 16:46
@jpraynaud
jpraynaud temporarily deployed to testing-preview June 5, 2024 16:54 — with GitHub Actions Inactive
@jpraynaud
jpraynaud temporarily deployed to testing-sanchonet June 5, 2024 16:54 — with GitHub Actions Inactive
@jpraynaud
jpraynaud temporarily deployed to testing-mainnet June 5, 2024 17:03 — with GitHub Actions Inactive
@jpraynaud
jpraynaud force-pushed the jpraynaud/1687-optimize-cardano-tx-proof branch from 11e53c5 to 5bd3c65 Compare June 11, 2024 13:58
@jpraynaud
jpraynaud temporarily deployed to testing-preview June 11, 2024 14:06 — with GitHub Actions Inactive
@jpraynaud
jpraynaud temporarily deployed to testing-sanchonet June 11, 2024 14:06 — with GitHub Actions Inactive
Comment thread mithril-common/src/chain_reader/pallas_chain_reader.rs Fixed
Comment thread mithril-common/src/chain_reader/pallas_chain_reader.rs Fixed
Comment thread mithril-aggregator/src/services/signature_processor.rs Fixed
Comment thread mithril-aggregator/src/services/signature_processor.rs Fixed
Comment thread mithril-common/src/crypto_helper/cardano/kes/signer_with_key.rs Fixed
Comment thread mithril-common/src/crypto_helper/cardano/kes/signer_with_key.rs Fixed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR appears to be an experiment to improve/inspect GitHub Actions E2E log grouping and retry behavior for dev networks, by adjusting E2E logging, CI retry/matrix behavior, and adding timing diagnostics during chain import.

Changes:

  • Re-enable GitHub Actions log grouping (::group:: / ::endgroup::) in the E2E test lab utilities.
  • Enable the allow_skip_signer_certification feature by default in mithril-common.
  • Add debug timing + counters around parsing/storing/rollback in the Cardano chain importer, and expand E2E CI attempts/logging.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

File Description
mithril-test-lab/mithril-end-to-end/src/utils/formatting.rs Re-enabled GitHub Actions log grouping markers around E2E logs.
mithril-common/Cargo.toml Changed default feature set to include allow_skip_signer_certification.
internal/cardano-node/mithril-cardano-node-chain/src/chain_importer/blocks_and_transactions_importer.rs Added debug logs for parse/store/rollback elapsed time and counts.
.github/workflows/ci.yml Increased E2E matrix repetitions and added retry step outputs / extra group logging.

Comment thread mithril-common/Cargo.toml

[features]
default = ["num-integer-backend"]
default = ["num-integer-backend", "allow_skip_signer_certification"]
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml
Comment on lines +454 to +456
echo "::group::Artificial group after e2e"
echo "This is a test"
echo "::endgroup::"
Comment thread mithril-common/Cargo.toml

[features]
default = ["num-integer-backend"]
default = ["num-integer-backend", "allow_skip_signer_certification"]
jpraynaud and others added 5 commits September 23, 2026 12:24
Re-activate as-is in order to see if there was some changes GH sides
that solved the previous problem: logs of a retried run were lost.
Lagrange genesis bootstrap requires a dual genesis key with 'future_snark',
not supported by the e2e until #3533 is merged.
Time the certificate and recursive proofs, setup retrieval and input preparation
in the stm clerk and provers, with the aggregator epoch service logger.

This branch was successfully deployed

2 active and 5 inactive (outdated) deployments
testing-preview — e473177f Deployed Sep 23, 2026 by jpraynaud via deploy-testing (testing-preview) #13539
dev-mainnet — 31b1fec8 Deployed May 11, 2026 by jpraynaud via deploy-testing (dev-mainnet) #353
dev-preview — 31b1fec8 Deployed May 11, 2026 by jpraynaud via deploy-testing (dev-preview) #352
dev-follower-preview — 31b1fec8 Deployed May 11, 2026 by jpraynaud via deploy-testing (dev-follower-preview) #351
testing-sanchonet — 7e951189 Deployed Feb 6, 2025 by jpraynaud
testing-mainnet — 7b61ae56 Deployed Oct 4, 2024 by jpraynaud
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge 🔒 Do not merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants