feat(plugin-mysql): add TiDB and Databend connection types - #5
Closed
J2TeamNNL wants to merge 11 commits into
Closed
feat(plugin-mysql): add TiDB and Databend connection types#5J2TeamNNL wants to merge 11 commits into
J2TeamNNL wants to merge 11 commits into
Conversation
Co-authored-by: Nguyễn Nam Long <J2TeamNNL@users.noreply.github.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…atabaseType moved to its own file Claude-Session: https://claude.ai/code/session_01Fvgf1oCG7h5qgmMDd8GfN6
…mysql-variants-135e Claude-Session: https://claude.ai/code/session_01EtSNyG8StyXn92NLdMFzsV
Owner
Author
|
Closing: this was a fork-only PR and cannot close upstream issues. The reviewable PR is TableProApp#2711 |
Co-authored-by: Cursor <cursoragent@cursor.com>
…n the MySQL driver Claude-Session: https://claude.ai/code/session_01EtSNyG8StyXn92NLdMFzsV
…mysql-variants-135e Claude-Session: https://claude.ai/code/session_01EtSNyG8StyXn92NLdMFzsV
… SHOW CREATE TABLE and never kill an idle TiDB session Claude-Session: https://claude.ai/code/session_01EtSNyG8StyXn92NLdMFzsV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes TableProApp#1066
Fixes TableProApp#2514
Summary
Adds TiDB and Databend as first-class connection types on the bundled MySQL plugin, the same pattern as MariaDB. No new C client. Both speak the MySQL protocol, so they reuse
MySQLPluginDriverthroughadditionalDatabaseTypeIds.TableProApp#2514 is the overlapping TiDB request (first-class type, icon, defaults, docs, and hiding features TiDB does not run). This PR does that. It does not add
INFORMATION_SCHEMA.CLUSTER_*in the sidebar, and it does not sniffVERSION()to rewrite a MySQL connection as TiDB. Those would be a follow-up if they are still wanted after this type exists.Defaults and capabilities
TiDB (
tidb://, port 4000, relational):information_schema,mysql,performance_schema,metrics_schema,sysMySQLDashboardProviderDatabend (
databend://, port 3307, analytical):system,information_schema,INFORMATION_SCHEMA(defaultstays visible)Wiring
Curated
PluginMetadataRegistrysnapshots,reverseTypeIndexsopluginTypeIdis stillMySQL, Info.plistTableProProvidesDatabaseTypeIds, URL schemes in the app plist, Docker Compose image detection (pingcap/tidb,datafuselabs/databend), and importers (TablePlus, DBeaver, DataGrip, Beekeeper, Navicat for TiDB). iOS factory, intents, and widget icons are updated so the types round-trip there too.Docs:
docs/databases/tidb.mdxanddatabend.mdx, engine count 29. Screenshots are omitted on purpose; the form is the MySQL form, same asmariadb.mdx.Tests
DatabaseTypeTiDBTests,DatabaseTypeDatabendTests,ConnectionURLParserTiDBTests,ConnectionURLParserDatabendTestsSqlDialect.from, Navicat TIDB, DBeaver mappings, TablePlus type mappingxcodebuildwas not run here (Linux cloud agent, no Xcode). CI on macOS has to compile and run the suite.Out of scope
VERSION()contains TiDB