PHP notice in SequenceMatcher.php

[brainfork]

My company was utilizing chrisboulton/php-diff in our code and have had to replace it as part of an ongoing upgrade to PHP 8. We've replaced that repo with this one and ran PHPStan scans on it which returned this notice:

  Line   \lib\Diff\SequenceMatcher.php
 ------ -------------------------------------------------------------
  372    Call to function unset() contains undefined variable $line.
 ------ -------------------------------------------------------------

I believe a fix for this would be to simply define $line = '' above the if statement here:

php-diff/lib/jblond/Diff/SequenceMatcher.php

Line 359 in 2dc8344

if ($this->options['ignoreLines'] == 2) {

[DigiLive]

Hello @brainfork,

Thank you for your feedback.
I think

php-diff/lib/jblond/Diff/SequenceMatcher.php

Line 372 in 2dc8344

unset($line);

can be removed all together.
Looks like the reference isn't kept after using array_walk(): https://3v4l.org/jAE8s

[DigiLive]

@JBlond You're picking this one up?

[JBlond]

Yes, I will. I'm busy, but as soon as possible I'm looking into this.

[JBlond]

@DigiLive Do we need to make a release?

[DigiLive]

The package will run just fine as currently released.
It's the user's analyzer which warns him about the necessary line.

IMHO, we don't need a release, but it will not harm anything.
You expect more changes anytime soon?