Repository navigation
fix(agents): address the PR 124 manual-testing findings - #140
Merged
Jacksondr5 merged 1 commit intoSep 14, 2026
Merged
Jacksondr5 merged 1 commit into
Jacksondr5 merged 1 commit into
Conversation
bryantderosier
added this pull request to stack #120
September 14, 2026 12:17
github-actions
Bot
added
vouch:trusted
bryantderosier
requested review from
BastiHu,
Jacksondr5 and
tyler-barton-horizon
September 14, 2026 12:25
bryantderosier
force-pushed
the
feature/agent-library-review-fixes
branch
from
September 14, 2026 12:37
1620e44 to
bdc3c12
Compare
Five fixes from Jackson's review of the agent library: - The primary/fallback model menu closes after a pick; Base UI radio items default to staying open. - Every listed agent has an On/Off switch. Imported copies keep their flag; folder and bundled ids are written to disabled-source-agent-personas.json through a new setAgentPersonaEnabled RPC, so switching one off never touches its file. An imported copy overrides its source's entry on that list. - Typing @ and the start of an agent's id or name lists matching agents above the file results on web and mobile, so @scout finds Scout; the explicit @agent: trigger still lists every launchable agent. Settings states the syntax. - The unconfigured default personas folder reads as the default with bundled examples in use rather than as Missing. - Blocked badges explain themselves: the catalog carries one attempt per rejected route with typed failure codes, and Settings shows which model or provider is missing, or that the runtime policy is not enforceable yet. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Jacksondr5
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jackson's manual pass on #124 turned up five things in the agent library. This PR fixes all five; the persona-on-
spawn_agentgap is covered by the crews work, and thedelegate_taskfold and the artifacts hookup follow as their own PRs.closeOnClick=false; the primary/fallback picker now closes on selection.<stateDir>/disabled-source-agent-personas.jsonthrough a newsetAgentPersonaEnabledRPC on the J5 group, so switching one off never touches its file, and an imported copy overrides its source's entry.@scoutopened the file picker. Typing@plus the start of an agent's id or name now lists matching agents above the file results on web and mobile (one appended spread in each composer's path branch, recorded in FORK.md);@agent:still lists every launchable agent. Settings → Agents states the syntax.personasrow now reads "Default · not created; bundled examples in use" instead of an error badge.attemptsentry per rejected route with typed failure codes, and the Blocked badge explains them: hover on web/desktop, inline lines on mobile (for example "Primary · Codex gpt-5.6-terra (high): model is not offered by the signed-in provider", or "runtime policy is not enforceable on this provider yet" fordiagnosticandpublish-only).Validation
Merge order
Part of GitHub stack
120, on top of #124.🤖 Generated with Claude Code