Skip to content

feat(crews): compose crews in chat and coordinate directly - #191

Merged
bryantderosier merged 2 commits into
crews/10-personas-vocabularyfrom
crews/11-conversational-collaboration
Sep 21, 2026
Merged

bryantderosier merged 2 commits into
crews/10-personas-vocabularyfrom
crews/11-conversational-collaboration

Conversation

@bryantderosier

@bryantderosier bryantderosier commented Sep 18, 2026 •

Copy link
Copy Markdown
Collaborator

Crew creation depended on a /crew composer path, and agent guidance encouraged final handoff files without clearly describing ongoing collaboration. Ask for a crew in ordinary chat now: the current agent proposes saved or custom members, and all members are instructed to exchange findings, blockers, and results directly. Captains request additional expertise through the existing human inbox approval.

Removes the Crew slash-command entry and prompt wrapper. Explicit persona handoff deliverables remain required, but never gate messages. Existing Astra active steering and other providers' safe queued delivery remain unchanged.

Base: crews/10-personas-vocabulary (PR #185); head: crews/11-conversational-collaboration. Entry 11 of stack pingdotgg#153; merge after #185 and before #192.

Validation: focused SQLite communication tests, spawn/prompt contracts, existing delivery integration coverage, scoped server/web typechecks. Native mobile crew approval remains unsupported.

Implemented with GPT-6-Astra (High) in Codex. Reviewed with Claude Fable 5.1 (High) through the Claude harness; the completed stack review found no blockers.

Closes #211.

@bryantderosier
bryantderosier added this pull request to stack #153 September 18, 2026 18:17
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 effective changed lines (test files excluded in mixed PRs). labels Sep 18, 2026
@bryantderosier bryantderosier changed the title crews/11 conversational collaboration feat(crews): compose crews in chat and coordinate directly Sep 18, 2026
@bryantderosier bryantderosier self-assigned this Sep 18, 2026
@bryantderosier
bryantderosier marked this pull request as ready for review September 18, 2026 18:48

@Jacksondr5 Jacksondr5 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Composing a Crew from ordinary chat and telling members to exchange findings directly is the right center of gravity, and this PR is a net deletion on the composer side: the ChatView and ChatComposer deltas remove only the earlier J5 appends, the standing instructions still satisfy every pinned and forbidden phrase in their test, and FORK.md case 8 follows.

One thing to take out. The <j5_crew_launch> parser in crewNotices.logic.ts and CrewLaunchCard in CrewNoticeRenderer.tsx are kept for "stored historical launch notices", and the test inlines the retired fixture to keep them covered. Those notices were only ever written by the /crew command this stack introduced and this PR removes; they exist on dev databases of the unmerged stack and nowhere else. docs/j5/process/working-in-the-repo.md, as written: "Pre-dogfood, no legacy-compatibility code, ever. Accommodations for data or states that cannot exist yet (no users, no legacy drafts) are YAGNI and get deleted." Delete the parser, the card, and the fixture; an old launch turn on a dev database renders as the raw text it is.

Also noted, not blocking: CrewCommunication.test.ts exercises send and proposal storage this PR does not change, so it passes by construction; AGENTS.md asks not to add tests that mirror the implementation.

Reviewed by Claude Fable 5.1 in Claude Code, with an independent pass by GPT-6-Astra in Codex.

Jacksondr5 added a commit that referenced this pull request Sep 20, 2026
…icit (#148, #191, #192)

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@Jacksondr5

Copy link
Copy Markdown
Owner

From Jackson's hands-on review, not blocking; fix or defer is your call.

The Captain solicits each member after launch, so every result arrives twice. Right after the launch report, the Captain opened an Exchange with each seat asking for its final joke. Each seat then answered that ask and also sent its result unprompted, as its brief told it to.

captain asking each seat for its result

The seat brief's <crew_collaboration> block tells members to send findings and results to the Captain. Nothing tells the Captain that. The launch report's footer says "the Captain has each reason" and stops there, and the standing Crew bullet says seats' finishes arrive as messages but not that their results do. One sentence in either place would close it: "Seats are told to message you with their results; do not ask for them, end your turn and read them as they arrive." The report (#148) is the more targeted spot since it is read at exactly that moment.

@bryantderosier
bryantderosier force-pushed the crews/11-conversational-collaboration branch from ea8d48e to 503cd79 Compare September 21, 2026 11:56
@bryantderosier

Copy link
Copy Markdown
Collaborator Author

Addressed the review and duplicate-results comment: removed the retired launch parser/card/fixture and the redundant CrewCommunication test. The launch-report footer now tells the Captain that seats send results themselves, to avoid asking for them again, and to end the turn and read them as they arrive. Focused notice and collaboration tests pass.

@bryantderosier
bryantderosier force-pushed the crews/11-conversational-collaboration branch from 503cd79 to fbbbda1 Compare September 21, 2026 12:16

@Jacksondr5 Jacksondr5 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The retired launch parser, card, and fixture are gone, the redundant communication test is gone, and the launch-report footer now tells the Captain that seats send results themselves, not to ask again, and to end the turn. Composing a Crew from ordinary chat with members messaging each other is the right center of gravity, and this PR is a net deletion on the composer side. Approving.

Reviewed by Claude Fable 5.1 in Claude Code, with an independent pass by GPT-6-Astra in Codex.

@bryantderosier
bryantderosier force-pushed the crews/11-conversational-collaboration branch from 927d537 to 9093b3e Compare September 21, 2026 15:07
@bryantderosier
bryantderosier merged commit c02e084 into j5/main Sep 21, 2026
19 checks passed
@bryantderosier
bryantderosier deleted the crews/11-conversational-collaboration branch September 21, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compose Crews in ordinary chat and let members coordinate directly

2 participants