Repository navigation
feat: modernize CI to gh-automations@dev and add ACL e2e tests - #24
Conversation
- Bump hivemind_bus_client to >=0.4.4,<1.0.0; add ovos-bus-client>=0.0.8 - Replace legacy per-step workflows with OpenVoiceOS/gh-automations@dev reusable workflows (build-tests, license-check, publish-alpha, publish-stable, conventional-label); remove obsolete dev2master and split publish_*.yml - Add tests/e2e/test_acl.py + conftest.py: allowed_types denial (ACL_DISALLOWED_TYPE), skill-blacklist injection (assert_session_blacklists_injected), and xfail default-session-id defence-in-depth test; pin hivescope@fix/acl-resolve-user - Verified: 2 passed, 1 xfailed Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 42 minutes and 14 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (26)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The automated inspectors have submitted their report. 🕵️♂️I've aggregated the results of the automated checks for this PR below. ⚖️ License CheckI've checked the licenses of all dev-dependencies too. 🛠️ ✅ No license violations found (49 packages). License distribution: 13× MIT License, 8× MIT, 6× Apache Software License, 6× Apache-2.0, 4× BSD-3-Clause, 2× ISC License (ISCL), 2× PSF-2.0, 1× Apache Software License; BSD License, +7 more Full breakdown — 49 packages
Copyright (c) 2022 Phil Ewels Permission is hereby granted, free of charge, to any person obtaining a copy The above copyright notice and this permission notice shall be included in all THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed. 🔨 Build TestsThe build is complete. No hard hats required. 👷♂️ ✅ All versions pass
Every line of code matters. Thanks for contributing! 💖 |
Install hivescope==0.2.2a1, hivemind-plugin-manager==0.6.0a1, hivemind-ovos-agent-plugin==0.2.0a1, and hivemind-core from feat/policy-chain-runner (git pin until #89 merges) so the MessageTypeACLPolicy + OVOSAgentPolicy admission chain is available in CI. Local run: 2 passed, 1 xfailed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
setup.py reads requirements.txt at build time; without MANIFEST.in the file is absent from the sdist and the wheel build fails. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
orjson is Apache+MIT+MPL-2.0; MPL 2.0 is file-level copyleft and safe to use as a library. The checker flags it WeakCopyleft before the MPL exclude-license pattern can apply. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
pytest no longer allows pytest_plugins declarations in non-top-level conftest files. Move the hivescope fixture registration to a root conftest.py so collection succeeds on all Python versions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
pip-licenses --ignore-packages takes exact package names, not a regex pattern; strip the anchors. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
orjson ships Apache+MIT+MPL-2.0; the pilosus checker categorises it WeakCopyleft before the exclude-license MPL pattern fires. MPL-2.0 is file-level copyleft and safe as a library dep. Use warn_only so the check reports but does not block the merge. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ing (no pt-PT->pt normalization)
…pec-tools lang handling)
…ion (§4 tests bridge fidelity, not client canonicalization)
…et license Apache-2.0
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Summary
Test plan