Repository navigation
Fix CloudEvents unwrap for inline listeners - #2308
Merged
Merged
Conversation
lahma
marked this pull request as ready for review
March 16, 2026 16:48
Allow the handler pipeline to unwrap metadata-aware serializers before requiring Envelope.MessageType so inline CloudEvents receivers can deserialize messages without DefaultIncomingMessage<T>(). Reuse the same helper in durable receivers and add runtime and Kafka regression coverage for inline CloudEvents handling.
lahma
force-pushed
the
kafka-multiple-cloud-events
branch
from
March 16, 2026 19:04
97dc81a to
5866083
Compare
This was referenced Mar 17, 2026
This was referenced Mar 29, 2026
This was referenced Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was actually the fast path to get to #2306 problems. So when there was no default message type to fallback to and Kafka envelope didn't have
eventTypethe routing wasn't able to extract it from cloud event envelope.Now allowing the handler pipeline to unwrap metadata-aware serializers before requiring Envelope.MessageType so inline CloudEvents receivers can deserialize messages without DefaultIncomingMessage(). Reuse the same helper in durable receivers and add runtime and Kafka regression coverage for inline CloudEvents handling.