Repository navigation
Fix stale pg_class stats for dead letter and outgoing table counts - #2459
Merged
Merged
Conversation
…ation failures After commit 1262a27 switched FetchCountsAsync to use pg_class estimation for outgoing and dead_letter tables, afterTruncateEnvelopeDataAsync was not updated to ANALYZE those tables after bulk deletes. This caused stale reltuples values to produce incorrect counts in tests that delete and re-insert dead letter rows. Fixes the 3 failing PostgresqlMessageStoreTests in CI: - move_dead_letter_messages_as_replayable_by_id_to_incoming - move_replayable_error_messages_to_incoming - delete_dead_letter_message_by_id Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Apr 9, 2026
This was referenced Apr 18, 2026
This was referenced Apr 25, 2026
This was referenced May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FetchCountsAsyncto usepg_classestimation for outgoing and dead letter tables,afterTruncateEnvelopeDataAsyncwas not updated toANALYZEthose tables after bulk deletesreltuplesvalues to produce incorrect counts (e.g.counts.DeadLetterreturning 3 instead of 1)ANALYZEon dead letter and outgoing tables after truncation, matching the existing pattern for partitioned incoming tablesFixes the 3 persistently failing tests in CI (run):
move_dead_letter_messages_as_replayable_by_id_to_incomingmove_replayable_error_messages_to_incomingdelete_dead_letter_message_by_idTest plan
PostgresqlMessageStoreTestspass locally🤖 Generated with Claude Code