Repository navigation
GH-5360 scaffold: don't plan every emitted event as an Apply on every stream - #5374
Merged
Merged
Conversation
…st one stream and starts another Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Member
Author
|
Ran: |
This was referenced Nov 6, 2026
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #5360.
When a slice has
.Against<A>()and.StartsStream<B>(),Emits<T>()carries no stream, so the scaffold planned every event as an Apply on both A and B. It now plans none for such a slice and adds a warning notice (new codeemitted-event-stream-ambiguous) naming the streams.Done: option 3 from the issue (notice instead of a plan). Left: option 1 (a lane on the emit,
.Emits<T>().On<Account>()) needs a JasperFx.Events change; option 2 (infer from existing Apply/Create). Slices that only use severalAgainst<>keep their current behaviour (GH-4895 tests rely on it).🤖 Generated with Claude Code