Skip to content

added inline annotations#59

Open
gasagna wants to merge 1 commit into
JuliaDiff:masterfrom
gasagna:pull-request/ba9da790
Open

added inline annotations#59
gasagna wants to merge 1 commit into
JuliaDiff:masterfrom
gasagna:pull-request/ba9da790

Conversation

@gasagna

@gasagna gasagna commented Sep 10, 2017

Copy link
Copy Markdown
Contributor

I have noticed consistent and significant speed ups (about 1.5x) in a largish private package by adding inline annotations to methods for +, -, /, * for dual numbers.

I have sprinkled @inline annotation around in other parts of the module to catch other use cases, but it might be too much.

@mlubin

mlubin commented Sep 12, 2017

Copy link
Copy Markdown
Contributor

@gasagna, ForwardDiff already incorporates improvements like this and has additional speedups over DualNumbers thanks to chunking (https://arxiv.org/abs/1607.07892).

@gasagna

gasagna commented Sep 12, 2017

Copy link
Copy Markdown
Contributor Author

Thanks. Any chance this will be merged or you reckon it is best to move to ForwardDiff as a dependency for my package?

@mlubin

mlubin commented Sep 12, 2017

Copy link
Copy Markdown
Contributor

I'm willing to provide commit access if you (or somebody else) would like to take on some maintenance responsibility.

@gasagna

gasagna commented Sep 14, 2017

Copy link
Copy Markdown
Contributor Author

Thanks, but I am not sure I want to step up as maintainer of this package :)

@KristofferC

Copy link
Copy Markdown
Collaborator

FWIW, 0.7 should make this PR not needed since the inlining heuristics are greatly improved. However, that doesn't help 0.6 so...

@dkarrasch

Copy link
Copy Markdown

I guess this can be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants