Skip to content

CI: extension frames check intermittently times out at "palette access inside a real modal shell" #1171

Closed

Description

@Juliusolsson05

scripts/check-extension-frames.mjs (run by src/main/extensions/electron.system.test.ts in the quality gate) intermittently fails on the macOS runner:

Error: palette access inside a real modal shell timed out: {"text":"Extension input fixture", ... "shell=modal" ...}
    at waitFor (main.cjs)
Error occurred in handler for 'extensions:runtime-host': Error: This extension does not declare activation for onCommand:managed.snapshot.

Seen twice:

Per the repo's rule that a waitFor timeout is not flakiness, this needs a root cause: most likely an ordering race between the modal shell mounting and the palette-access probe. Don't widen the timeout.

🤖 Generated with Claude Code

Activity

  1. Juliusolsson05 commented on Sep 25, 2026

    @Juliusolsson05
    OwnerAuthor

    Another occurrence on PR #1105 (head 0ccc33d8): https://github.com/Juliusolsson05/agent-code/actions/runs/36076581349. That PR does not touch src/main/extensions/ or anything the harness imports (renderer-only, plus one new kill-caller string), so it is independent of the change under test.

  2. Juliusolsson05 commented on Sep 25, 2026

    @Juliusolsson05
    OwnerAuthor

    Two more occurrences, same signature (palette access inside a real modal shell timed out → Extension Electron checks failed (1)):

    🤖 Generated with Claude Code

  3. Juliusolsson05 commented on Sep 25, 2026

    @Juliusolsson05
    OwnerAuthor

    Fixed by #1300 (merged 1d25b0ed). This is the same failure as #1261: the palette chord was pressed before Electron's focusedFrame reached the extension frame. The harness now waits for the focused frame, matched by processId + routingId, for both the pane step and the modal step, without widening any budget. Reopen if palette access inside a real modal shell timed out recurs on a head that contains 1d25b0ed. The real-app gap (a chord does nothing until the modal iframe has focus) is #1307.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    class:C9-testsTest hygienesev:P2Real bug with a workaroundtype:bugSomething works wrong

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions