Skip to content

bug(workspace): Spotlight and Tiled Tabs ignore the Status Mode and worktree badge settings #856

Closed

Description

@Juliusolsson05

Expected

Settings → Status Mode and Settings → worktree badges apply to every workspace surface that renders agent panes: Grid, Dispatch, Tiled Dispatch, Spotlight and Tiled Tabs.

Actual

Spotlight and Tiled Tabs ignore both settings. With Status Mode off, a spotlighted pane, or any pane in Tiled Tabs, still fills its header with the accent color while the agent runs. Worktree badges show the same way when disabled.

Root cause

TileTree and renderWorkspaceLeaf (src/renderer/src/workspace/tile-tree/TileTree.tsx) default showStatusMode and showWorktreeBadges to true. SpotlightView calls renderWorkspaceLeaf(...) without them, and TileTabsView renders <TileTree> without them, so both always get the defaults. MainSurface passes these views only agentViewMode. git log -S showStatusMode shows neither view has ever received the props; it is an omission, not a design choice.

Reproduce

  1. Turn Status Mode off in Settings.
  2. Spotlight a running agent, or open Tiled Tabs while an agent runs.
  3. The pane header lights up anyway. Grid and Dispatch correctly stay unlit.

Impact

User-visible: the settings don't do what they say on two surfaces. Found in review of #853, which would otherwise have extended the same wrong default to terminal-view panes.

Environment

main at 48ea691.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions