Repository navigation
fix(command-palette): pin the generated Grok split commands in the catalog snapshot - #1019
Merged
Merged
Conversation
…talog snapshot main has been red since #844 merged: registering grok in AGENT_PROVIDER_KINDS generates grok-vertical and grok-horizontal, taking the catalog from 132 to 134 commands. #844 never touched catalog.test.ts because those ids are generated rather than literal, so its author had no diff here to notice. The generated-splits invariant in the file names this exact case. The snapshot, the count, the literal/generated split (134 - 6 = 128, unchanged) and the governance arithmetic (subtrahend 35 -> 37, right-hand side stays at the 102 baseline, per the file's own rule) all move together in this one commit, as the file requires. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Juliusolsson05
added a commit
that referenced
this pull request
Sep 19, 2026
Pick up #1019 so CI measures this PR against the now-green main. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This was referenced Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
mainhas been red since #844 (Grok app integration) merged:catalog.test.tsfails 3 tests (expected 134 … to have a length of 132, and the governance arithmeticexpected 104 to be 102). Every open PR's quality-gate inherits the failure. Because "Test core" fails first, the system, renderer, coverage and distributable steps have not run on main since then either.Cause: #844 added
groktoAGENT_PROVIDER_KINDS, which generatesgrok-vertical/grok-horizontal. #844 never touchedcatalog.test.ts, because those ids are generated rather than literal, so there was no diff here for its review to catch.Linked
Fixes #1016. Its second item, the media-census failure in
imageAttachment.test.ts, is local-environment only: it passes 17/17 on CI and fails locally only because a cited Claude session was deleted from disk. Evidence is in the issue comment. The catalog snapshot is the sole cause of main's red CI.Implemented
One test file, moved together as the file's own rule requires:
grok-verticalandgrok-horizontalafter the OpenCode splits (their real registration order);134 - 6 = 128. The literal count is unchanged, which is what shows the growth is purely generated;Decision
The Grok splits are intended. #844 registers grok "in every compile-forced row" as a first-class provider (switch, duplicate and rewind into Grok all work), and the split commands follow by construction. So the fix is to pin them, not to exclude grok from the generator.
Verification
npx vitest run --project unit src/renderer/src/features/command-palette/catalog.test.ts: 24/24 pass (3 failed before, on origin/mainc3614cb8).🤖 Generated with Claude Code