Skip to content

fix(command-palette): pin the generated Grok split commands in the catalog snapshot - #1019

Merged
Juliusolsson05 merged 1 commit into
mainfrom
fix/catalog-grok-command-count
Sep 19, 2026
Merged

Juliusolsson05 merged 1 commit into
mainfrom
fix/catalog-grok-command-count

Conversation

@Juliusolsson05

@Juliusolsson05 Juliusolsson05 commented Sep 19, 2026 •

Copy link
Copy Markdown
Owner

Problem

main has been red since #844 (Grok app integration) merged: catalog.test.ts fails 3 tests (expected 134 … to have a length of 132, and the governance arithmetic expected 104 to be 102). Every open PR's quality-gate inherits the failure. Because "Test core" fails first, the system, renderer, coverage and distributable steps have not run on main since then either.

Cause: #844 added grok to AGENT_PROVIDER_KINDS, which generates grok-vertical / grok-horizontal. #844 never touched catalog.test.ts, because those ids are generated rather than literal, so there was no diff here for its review to catch.

Linked

Fixes #1016. Its second item, the media-census failure in imageAttachment.test.ts, is local-environment only: it passes 17/17 on CI and fails locally only because a cited Claude session was deleted from disk. Evidence is in the issue comment. The catalog snapshot is the sole cause of main's red CI.

Implemented

One test file, moved together as the file's own rule requires:

  • the ordered snapshot gains grok-vertical and grok-horizontal after the OpenCode splits (their real registration order);
  • counts 132 → 134 in the titles, the count assertion and its history chain;
  • literal/generated accounting: 134 - 6 = 128. The literal count is unchanged, which is what shows the growth is purely generated;
  • governance arithmetic: the subtrahend goes 35 → 37 and the right-hand side stays at the 102 baseline, per the in-file rule "raise the subtrahend, never the right-hand side".

Decision

The Grok splits are intended. #844 registers grok "in every compile-forced row" as a first-class provider (switch, duplicate and rewind into Grok all work), and the split commands follow by construction. So the fix is to pin them, not to exclude grok from the generator.

Verification

  • npx vitest run --project unit src/renderer/src/features/command-palette/catalog.test.ts: 24/24 pass (3 failed before, on origin/main c3614cb8).
  • This PR's CI is the first full quality-gate run on current main since feat(grok): build native provider integration #844, covering the system, renderer, coverage and distributable steps that were skipped. Any failure there is pre-existing on main and gets fixed before merge, not waved through.

🤖 Generated with Claude Code

…talog snapshot

main has been red since #844 merged: registering grok in
AGENT_PROVIDER_KINDS generates grok-vertical and grok-horizontal, taking
the catalog from 132 to 134 commands. #844 never touched catalog.test.ts
because those ids are generated rather than literal, so its author had no
diff here to notice. The generated-splits invariant in the file names this
exact case.

The snapshot, the count, the literal/generated split (134 - 6 = 128,
unchanged) and the governance arithmetic (subtrahend 35 -> 37, right-hand
side stays at the 102 baseline, per the file's own rule) all move
together in this one commit, as the file requires.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@Juliusolsson05
Juliusolsson05 merged commit cbaf48a into main Sep 19, 2026
2 checks passed
@Juliusolsson05
Juliusolsson05 deleted the fix/catalog-grok-command-count branch September 19, 2026 05:25
Juliusolsson05 added a commit that referenced this pull request Sep 19, 2026
Pick up #1019 so CI measures this PR against the now-green main.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(grok): PR #844 left command-catalog and media-census baselines stale

1 participant