Repository navigation
fix(conversations): a failed in-place resume is reported on its pane (#1241) - #1262
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ad of nothing The picker closed and then awaited replaceSession from a `void` caller: a spawn failure (for example the recorded posix_spawnp error) became an unhandled rejection, and an undefined result was silent, so the pane just stayed as it was. The target pane is now read before closing, and every failure toasts its reason there, like builtInMcpReload does. With no pane to resume into, the picker stays open and says so. Closes #1241 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ume-in-place-failure
…handled paths - Steering q22 / review B: the toast showed the raw spawn IPC rejection, which can carry environment values, proxy URLs or scoped MCP tokens. It now says `Couldn't resume <label>: Session failed to start. Check provider setup and retry.` (the shared SESSION_START_FAILED_MESSAGE), and the test asserts no raw text. - Review A: the new-tab branch no longer ends in an unhandled rejection (newTab already toasts). usePaneToast ignores panes that are gone, so a toast for a pane closed mid-spawn can no longer recreate a dead runtime row forever; this also fixes builtInMcpReload's shape. - Review B: moving the highlight clears an inline error that named the previous row; the full texts and "no toast on success" are pinned. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… pane (#1262 round 2) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ume-in-place-failure
…ume-in-place-failure
Owner
Author
|
Review disposition (2 rounds, then merge on green)
CI quality-gate is green on a head that contains origin/main. Closes #1241. 🤖 Generated with Claude Code |
Juliusolsson05
deleted the
fix/conversations-resume-in-place-failure
branch
September 25, 2026 13:40
Juliusolsson05
added a commit
that referenced
this pull request
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1241.
Verified failure
The picker closed, then awaited
workspace.replaceSession(...)from avoidcaller:posix_spawnp failed) was an unhandled rejection, visible to nobody;undefinedresult (no target, missing meta, a refused commit) was silent.The pane simply didn't change. Plan:
docs/plans/2026-09-25-conversations-resume-in-place-failure.md(plan-only commit first).Fix
builtInMcpReload.Evidence
undefinedoutcome, and no target. Red on main, including the unhandled rejection; all three branches are mutation-checked.tsc -bis clean.Not verified
Visual toast placement in the running app (not launched).
🤖 Generated with Claude Code