Repository navigation
chore(deps): codex-headless proxy mirror writes chunks as base64 (Refs #372) - #1317
Merged
Merged
Conversation
…hunks as base64 (refs #372) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Sep 25, 2026
Owner
Author
|
Final disposition (pre-merge), head 45fffac. Three independent reviewers, one round each, on the app PR: A (pointer and metadata), B (app integration), C (measurement and forensic value). The package change has its own disposition on codex-headless#53, merged as
I checked the pointer myself. The head's Findings and dispositions:
Residuals:
Merges through batch PR #1318 once every member passes its gate. 🤖 Generated with Claude Code |
This was referenced Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #372. #372 stays open for per-file caps, dropped counters, request-body mirroring and the synchronous write.
Bumps
packages/codex-headlessae0e935→d7d7a5d, the merge of Juliusolsson05/codex-headless#53. That range holds only #53's commits: plan, fix and two test commits. Nopackage.jsonor lockfile change, so there is no lockfile resync.Why
Codex proxy dumps (
~/.config/agent-code/proxy/**/proxy-events.jsonl) have stored every response chunk as a decimal byte array.JSON.stringifyrunsBuffer#toJSONbefore the mirror's replacer sees the value. That is 3.65× the payload: in one recorded session file, 2,266 MiB of chunk lines held 621 MiB of bytes. A later snapshot of the same session measured 3.646×.What merges
{ _buffer_b64 }), asAPI.mdalways documented. The recorded bytes round-trip unchanged.Buffer.Tests
Package:
responsesProxy.mirror.test.tspasses (6 tests), including the recorded chunk, a full-size chunk, a nested Buffer and a split UTF-8 chunk. The app diff is the gitlink only.npx tsc -bis clean.Review
Three reviewers checked this app PR (A pointer and metadata, B app integration, C measurement). The package PR's own disposition is on codex-headless#53. Its fixture was sanitized under steering q36.
Residual
The proxy mirror still has no per-file cap and no dropped-write counter. It still mirrors request bodies, and it still writes synchronously inside
emit(#372).🤖 Generated with Claude Code