Repository navigation
chore(packages): bump the live-test credential and residue fixes (#1295) - #1463
Merged
Juliusolsson05 merged 2 commits intoSep 27, 2026
Merged
Juliusolsson05 merged 2 commits into
Juliusolsson05 merged 2 commits into
Conversation
…, #1329) - agent-transcript-parser 68dbfff -> 7e8a67c (#37): the Claude native-resume live test owns its probe launches and never touches the real login. - workflow-mcp ef995af -> 6bcaf113 (#63): the Codex live test gets an access-only login, never a copy of the real ~/.codex/auth.json. - claude-code-headless f52fc82 -> 1cfa8c92 (#68): the composer canary leaves no transcript or cwd, and one shared trust entry. All three package diffs are test-only (no package.json change), so the lockfile needs no resync; npm's own resync only dropped unrelated optional peer entries, which were left out. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
workflow-mcp#71 merged after #63: one shared pollUntil and run waits that end on every terminal status replace the 0.5 s counted polls that failed package CI. Test-only (six test files), so the lockfile still needs no resync (npm ci --dry-run accepts it). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
Review disposition (round 1: a, b, c codex at
|
| Reviewer | Focus | Result |
|---|---|---|
| a | Pointer integrity and supply chain | Each gitlink is a fast-forward to the package PR's merge commit on that package's origin/main (workflow-mcp 513374d5 → 6bcaf113 (#63) → the old pin). Every changed path is under test/, testing/, vitest.config.ts or .gitignore. No src/, manifest, bin or publish-files change, so no app build input or shipped package content changes. npm ci --dry-run exits 0 on the unchanged lockfile. |
| b | App CI and test wiring | App Vitest and the tsc project references never collect package test/ trees, and npx tsc -b prints 0 lines. check-test-contract scans package tests for .only and passes. Noted: release and preview builds run npm --prefix packages/workflow-mcp test, which now includes #71's converted polls and #63's helper test; they are green in package CI (8/8), and the live Codex test stays excluded. The body's scope claims match the diff. |
| c | Safety of the pinned live-test helpers | None can copy a refresh token, strand real credentials or delete outside its own run. Three safety mutants are red: the parser inheriting CLAUDE_CONFIG_DIR, the Codex snapshot copying the refresh token, and the target-symlink guard removed. Package core suites pass: parser 228, workflow-mcp 169, claude-code-headless 179. The disclosed residuals are unchanged: one trust entry per checkout family, the mkdtemp/lstat race and the NFC transcript directory. |
Nothing to fix. Labels: type:chore, class:C9-tests, sev:P1 (from #1295).
merge-gate.sh agent-code 1463 --member --dry: GATE PASS (e8d3b3e3, 0 behind main, checks green, reviews OK). READY.
Juliusolsson05
changed the base branch from
main
to
integration/batch-2026-09-27-q
September 27, 2026 21:04
Juliusolsson05
merged commit Sep 27, 2026
d71c35a
into
integration/batch-2026-09-27-q
2 checks passed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1295. Refs #1329 (already closed by claude-code-headless#68's merge; this makes the app pin it).
Pointer bumps only; the manager authorized them under the PR freeze (
temp/manager/assign/w4-pkg-1950.md). Each package PR was reviewed, manager-verified and merged in its own repo. This PR gets its own three reviews.68dbfff→7e8a67cef995af→513374d5~/.codex/auth.json, so refresh-token rotation can no longer log the developer out. #71: one sharedpollUntil, with run waits that end on every terminal status, replaces the 0.5 s counted polls that failed package CI.f52fc82→1cfa8c92~/.claude, and adds one shared trust entry per checkout family.All three diffs are test-only. They touch
test/,testing/,vitest.config.tsand.gitignore, and no package'spackage.jsonchanges. So nothing the app builds or ships changes, and the lockfile needs no resync.npm ci --dry-runaccepts the unchanged lockfile. (npm install --package-lock-onlyonly dropped unrelated optional peer entries, and I left that out.)Residuals carried from the package reviews:
mkdtemp→lstatrace (owner option A).🤖 Generated with Claude Code