Skip to content

feat(feed): establish Codex rendering foundation #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Juliusolsson05 merged 1 commit into from
May 16, 2026
Merged

feat(feed): establish Codex rendering foundation #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions docs/codex-rewrite-render/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
# Codex Render Rewrite Notes

This directory is the working notebook for rebuilding feed rendering from first principles while keeping live streaming.

## Current Principle

The feed renderer must not blend sources opportunistically. It should select from explicit owners:

- `committed`: durable transcript / rollout entries.
- `semantic-history`: completed live turns that are still waiting for committed catch-up.
- `semantic-current`: the current live streaming turn.
- `work`: phase-only agent activity, independent from text rows.
- `empty`: placeholder when no row owner has content.

The first implementation pass introduces `deriveFeedRenderModel` in `src/renderer/src/features/feed/model/renderModel.ts`. `Feed.tsx` now asks that selector what to paint instead of recomputing committed visibility, semantic ownership, and RENDER debug rows inline.

## Findings

- `upstream-codex-rendering.md`: Codex upstream separates raw provider deltas, core UI events, and rollout persistence. We should keep those layers distinct.
- `headless-channel-model.md`: headless exposes semantic, screen, and committed planes. Screen may drive diagnostics/phase, but it must not be a second assistant-text owner in Feed.
- `renderer-runtime-ingestion.md`: renderer state already contains committed entries, semantic current/history, ghosts, and stream phase. The bug class appears when those owners are selected in separate JSX branches.
- `feed-ui-rendering.md`: Feed had many local duplicate guards, but no single visible-unit selector.
- `submit-queue-debug.md`: draft/submitted/queued/committed prompt states are different owners; queued prompts should not become transcript rows.

## Implemented In This Branch

- Extracted a pure render selector:
- committed entry visibility decisions,
- Claude-only semantic-history turn suppression,
- Codex-safe semantic unit suppression via committed tool/text ownership,
- independent work-row modeling,
- RENDER debug rows derived from the same model Feed uses to paint.
- Exported semantic ownership helpers from `renderUnits.ts` so debug/model decisions cannot claim a semantic row that `SemanticStreamingTurn` would later return as `null`.
- Added stable current semantic turn keys and turn-scoped semantic block keys.
- Added `scripts/test-feed-render-model.ts` and `npm run test:feed-render-model`.

## Remaining Work

- Move more semantic ownership out of React components and into the selector so Feed can eventually render a single typed `FeedRenderItem[]`.
- Add a renderer trace command that logs committed, semantic, and work owner candidates before selection and after selection.
- Investigate the Codex headless rollout lifecycle issue documented in `headless-channel-model.md`: rollout `agent_message_delta` may need to soft-open a semantic turn before applying deltas.
Loading