Repository navigation
feat(dispatch): attach-all in grid mode + project terminal setting - #69
Merged
Juliusolsson05 merged 2 commits intoMay 11, 2026
Merged
Conversation
The command was gated by dispatchCommandTabId, which returned null whenever the workspace was not in Dispatch — so users with parked agents had to first flip into Dispatch just to bring them back. Replace the resolver with attachAllCommandTabId: delegates to the dispatch-aware resolver when in Dispatch (preserves global Dispatch behavior, where the focused row may live on a different tab), and falls back to activeTabId in grid mode. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Replace the per-session dispatchMode.terminalVisible flag (and its command-palette toggle) with a global setting, settings.dispatchProjectTerminal, defaulting to false. The previous design re-defaulted to ON whenever a fresh workspace or new tab entered Dispatch — that's the "I turned it off but it came back" failure mode users have been hitting. - Add the setting + DEFAULT_SETTINGS entry + coerceSettings rule - New Settings → Workspace entry: "Attach Project Terminal to Dispatch" - DispatchLayout reads settings.dispatchProjectTerminal; if OFF, the terminal pane neither mounts nor takes layout space - Remove toggleDispatchTerminal action + its command-palette command - Drop terminalVisible from DispatchModeState (old workspace.json entries silently ignore the unknown field) - enterDispatchMode / setDispatchScope no longer call ensureDispatchTerminal unconditionally — DispatchLayout's effect is the only call site, gated by the setting Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 13, 2026
Juliusolsson05
deleted the
feat-dispatch-attach-regular-and-terminal-setting
branch
July 7, 2026 21:56
This was referenced Sep 27, 2026
Juliusolsson05
added a commit
that referenced
this pull request
Sep 27, 2026
… hold lifted) #69 merged after its own round 1 (since is a poll-start lower bound; a request-only flow that provably starts after the gap streams; the phase owner is sealed last). The app API is unchanged; no lockfile entry to resync. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two related dispatch polish fixes in one PR.
Part A —
Attach All Dispatch Agents For Tabworks in grid modeThe command was gated by
dispatchCommandTabId, which returnsnullwhenever the workspace is not in Dispatch. That forced users with parked agents to first flip into Dispatch just to bring them back into the grid — friction with no upside.Replaced with
attachAllCommandTabId:dispatchCommandTabIdso global Dispatch can still target the focused row's tab (which may differ fromactiveTabId).state.activeTabId. The command appears whenever the active tab has detached agents waiting.attach-detached-to-grid(the single-agent picker) stays dispatch-only — it needs a dispatch-focused session as its target, so there is no clean grid-mode meaning.Part B — Dispatch project terminal is a setting, off by default
The dispatch terminal was gated by an ephemeral
dispatchMode.terminalVisibleflag in workspace state. That flag re-defaulted to ON every time Dispatch was re-entered (fresh workspace, new tab, scope switch) — the "I turned it off but it came back" failure mode the user has been hitting.settings.dispatchProjectTerminal: booleaninapp-state/settings/types.ts, defaultfalse, coerced strictly (=== true) so missing/malformed values stay off.DispatchLayoutreads the setting and conditionally mounts the terminal pane + claims layout space. When OFF the agent panel takesbasis-full.toggleDispatchTerminalaction + thetoggle-dispatch-terminalcommand (per the user request: "settting defined in settings, not a command").terminalVisiblefromDispatchModeState; olderworkspace.jsonentries with the field are harmlessly ignored.enterDispatchMode/setDispatchScopeno longer callensureDispatchTerminalthemselves. The DispatchLayoutuseEffectis the only spawn site now, gated by the setting — so flipping the setting OFF and re-entering Dispatch cannot silently spawn a fresh terminal.Test plan
🤖 Generated with Claude Code