Truncate long display names on the profile widget#30
Open
eudanielhenrique wants to merge 1 commit into
Open
Conversation
Closes the "Truncate name if too long" TO-DO item. Long GitHub display names ran into the data boxes on the right side of the card (which shift further left the more &data= options are requested). The name is now truncated with an ellipsis to fit the space actually available for the given number of data boxes. Also escapes the name, login, and URL text so a display name containing &, <, or > can't break the SVG's XML structure — it was being interpolated raw before.
|
@eudanielhenrique is attempting to deploy a commit to the Jurre's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the "Truncate name if too long" TO-DO item.
Long GitHub display names ran into the data boxes on the right side of the card (which shift further left the more
&data=options are requested). The name is now truncated with an ellipsis to fit the space actually available for the given number of data boxes (1–4).Also escapes the name, login, and URL text so a display name containing
&,<, or>can't break the SVG's XML structure — it was being interpolated raw before.Test plan
npm run buildcompiles cleanly