Skip to content

Correct name of proposal folder - #1728

Merged
vladomit merged 10 commits into
KTH:2022from
Neproxx:tutorial-pr
Apr 13, 2022
Merged

Correct name of proposal folder#1728
vladomit merged 10 commits into
KTH:2022from
Neproxx:tutorial-pr

Conversation

@Neproxx

@Neproxx Neproxx commented Apr 6, 2022

Copy link
Copy Markdown

Unfortunately, I forgot to rename the folder of my proposal README after having added someone to collaborate with. This pr changes the folder name from "marcelj" to "marcelj-khalidey". Please also create a group marcelj-khalidey in canvas after accepting the pr. The current group "marcelj" can however be used for my essay proposal that I will work on alone. Thanks.

@dd2482-bot

Copy link
Copy Markdown
Collaborator

Student marcelj already registered for this task

@khesoem

khesoem commented Apr 12, 2022

Copy link
Copy Markdown

@vladomitrovic This PR is changing the folder name to add a student whose name was missing. Can we merge it?

@khesoem khesoem self-assigned this Apr 12, 2022
@khesoem khesoem added enhancement New feature or request and removed enhancement New feature or request labels Apr 12, 2022
@dd2482-bot

Copy link
Copy Markdown
Collaborator

Student paulinev already registered for this task

If not from your group, fetch the upstream.

@vladomit
vladomit merged commit b293d15 into KTH:2022 Apr 13, 2022
@vladomit

vladomit commented Apr 13, 2022

Copy link
Copy Markdown

@khaes-kth I merged the PR

The best is to first delete the previous group or rename it manually on canvas before merging.

Because the for some reason the changes of this PR are adding a new directory and not renaming it, even if this was the case in the forked repo

Something to investigate....

@khesoem

khesoem commented Apr 13, 2022

Copy link
Copy Markdown

Thanks @vladomitrovic

Do we have to take any other actions with respect to this specific PR and group?

@vladomit

vladomit commented Apr 13, 2022

Copy link
Copy Markdown

Do we have to take any other actions with respect to this specific PR and group?

No, everything is sync now.

I just opened an issue on kth/github-canvas-integration in order to have it somewhere for future improvements of the bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants