Restore blank-line separators in grading-criteria.md - #2943
Merged
Conversation
update_grading.py's parse_criteria() splits each section on double-blank lines (\n\n\n) into title/description/table/grading-note. Most sections had collapsed to single blank lines at some point, so the parser saw only 1 part per section instead of 4 and crashed with IndexError on the first one it hit (Project). Restored the double blank lines for the five sections that have a criteria table; Project is left alone since it has no fixed criteria yet (companion fix in KTH/github-canvas-integration-devops makes the parser skip such sections instead of crashing).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most sections collapsed to single blank lines, so update_grading.py's parser (splits on double-blank-line) saw 1 part instead of 4 and crashed. Restored double blank lines for the 5 sections with tables. Project untouched (no fixed criteria yet — companion fix in KTH/github-canvas-integration-devops#7 skips it gracefully).