TEMP: point update-criteria at fork fix branch to verify Canvas sync - #2946
Merged
Conversation
Mirrors the existing TEMP override on check_task_canvas.yml (#2944). Verifies KTH/github-canvas-integration-devops#7 before someone with access merges it to main. Revert once that PR merges.
No-op trailing newline. update_criteria.yml only fires on push to 2026 when this file changes, so this triggers the workflow to verify the fork fix (see previous commit) actually syncs categories to Canvas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check_task_canvas.yml(TEMP: point check-canvas at fork fix branch #2944): pointsupdate_criteria.yml's "Get tools" checkout atalgomaster99/github-canvas-integration-devops@fix/replace-presentation-with-project(upstream PR KTH/github-canvas-integration-devops#7) instead ofmain.main'supdate_grading.py::parse_criteria()crashes withIndexError: list index out of rangeon the## Projectsection (it has no criteria table, unlike the other sections), which has caused theGrading criteriaworkflow to fail on every push tograding-criteria.mdsince Add grading criteria for KTH DevOps course #2928 — meaning Canvas has never had its 2026 group categories created (confirmed viacheck_task_canvas.ymlon [TOY] Scientific paper proposal: CI check test, week 2 #2945 loggingCANVAS_GROUPS_SET {}).Project) instead of crashing, per team decision to skip Project for now.grading-criteria.md, sinceupdate_criteria.ymlonly triggers on push to2026when that file changes — needed to actually retrigger the workflow and verify the fix against real Canvas.Test plan
Grading criteriaworkflow run succeeds (noIndexError)check_task_canvas.ymlon an open scientific-paper PR (e.g. [TOY] Scientific paper proposal: CI check test, week 2 #2945) and confirmCANVAS_GROUPS_SETis no longer emptymain, revert this TEMP commit (and the matching one from TEMP: point check-canvas at fork fix branch #2944) to point both workflows back atmain