Skip to content

TEMP: point update-criteria at fork fix branch to verify Canvas sync - #2946

Merged
algomaster99 merged 2 commits into
2026from
temp/point-update-criteria-fork
Aug 29, 2026
Merged

TEMP: point update-criteria at fork fix branch to verify Canvas sync#2946
algomaster99 merged 2 commits into
2026from
temp/point-update-criteria-fork

Conversation

@algomaster99

Copy link
Copy Markdown
Collaborator

Summary

  • Mirrors the existing TEMP override on check_task_canvas.yml (TEMP: point check-canvas at fork fix branch #2944): points update_criteria.yml's "Get tools" checkout at algomaster99/github-canvas-integration-devops@fix/replace-presentation-with-project (upstream PR KTH/github-canvas-integration-devops#7) instead of main.
  • main's update_grading.py::parse_criteria() crashes with IndexError: list index out of range on the ## Project section (it has no criteria table, unlike the other sections), which has caused the Grading criteria workflow to fail on every push to grading-criteria.md since Add grading criteria for KTH DevOps course #2928 — meaning Canvas has never had its 2026 group categories created (confirmed via check_task_canvas.yml on [TOY] Scientific paper proposal: CI check test, week 2 #2945 logging CANVAS_GROUPS_SET {}).
  • The fork branch skips sections without a full criteria table (like Project) instead of crashing, per team decision to skip Project for now.
  • Second commit is a no-op trailing-newline touch to grading-criteria.md, since update_criteria.yml only triggers on push to 2026 when that file changes — needed to actually retrigger the workflow and verify the fix against real Canvas.

Test plan

Mirrors the existing TEMP override on check_task_canvas.yml
(#2944). Verifies KTH/github-canvas-integration-devops#7
before someone with access merges it to main. Revert once that PR merges.
No-op trailing newline. update_criteria.yml only fires on push to 2026
when this file changes, so this triggers the workflow to verify the
fork fix (see previous commit) actually syncs categories to Canvas.
@algomaster99
algomaster99 merged commit 54a4f91 into 2026 Aug 29, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant