Repository navigation
選択したキーボードのみをプレビュー / Preview only the selected keyboard - #1344
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
日本語
新規設定の「いまのキーボード」を「キーボードのプレビュー」に変更し、選択対象の1配列だけを表示します。実際のIMEで最後に選択された配列が同じプロセス内で分かる場合はそれを利用し、未取得・削除済み・無効な場合は起動時の選択設定から解決します。カスタム配列は安定IDで特定し、保存済みの全配列を並べません。
通常のキーボード表示・カスタム配列切替・分割キーボード開始から選択状態を通知します。お試し入力は選択状態を書き換えず、サービス破棄時には破棄します。画面再生成で古い閲覧ページが優先されることも防ぎます。フリーフリック編集プレビューの寸法には変更を加えていません。
検証: 関連ユニットテスト10件成功。API 35の分離Liteアプリで、保存したファミリー、カスタム安定ID、削除後のフォールバック、再生成、外観編集からの復帰を確認。外部の計測用APKから実IMEを表示し、スミレ入力の選択状態が通知されることを確認。画面テスト3件成功。QWERTYのプレビュー/実IMEのお試し入力比較と、保存選択を書き換えないことも確認しました。全配列を回す最初の実行は、操作待ちタイムアウト後のスクリーンショット取得nullで失敗したことを後からlogcatで確認しました。成功件数には含めていません。実機・Full版と全キーボードの寸法比較は未確認です。
English
Rename “Your keyboard” to “Keyboard preview” and show one selected layout. Prefer the last real IME selection available in this process; otherwise resolve the startup selection, rejecting disabled or deleted targets. Resolve custom layouts by stable ID instead of expanding every saved layout.
Publish selection from real keyboard display, custom layout changes and split keyboard startup. Trial typing does not replace this state, and service destruction clears it. Activity recreation no longer prioritizes an old browsing page. Free Flick editor preview dimensions are untouched.
Validation: 10 related unit tests passed. An isolated Lite app on API 35 covers saved family/custom selection, deletion fallback, recreation and returning from appearance editing. An external probe verified that the real Sumire IME publishes its selection. 3 UI tests passed, including a QWERTY preview-versus-real-IME trial comparison and unchanged remembered selection. Logcat later confirmed that the first all-layout run failed when screenshot capture returned null after an interaction wait timed out; it is not counted as a success. Physical-device/Full-edition UI and exhaustive geometry comparisons remain untested.