Repository navigation
共有サイドメニューと下部タブ編集 / Share editable side menu and bottom tabs - #1345
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
日本語
新規・従来設定で、編集可能なサイドメニューと画面下のタブを共有します。従来の上部タブは従来どおり固定です。
サイドメニューの初期表示は、設定トップ・検索・キーボードの選択・見た目と配置・学習辞書・ユーザー辞書・定型文・カスタムキーボードの8画面です。「表示を編集」から「サイドメニュー」「画面下のタブ」を選び、画面を追加・削除・並べ替えできます。項目名は固定です。全設定カテゴリは追加候補として用意します。
下部は既存5画面を初期状態で維持し、最大5項目を配置できます。バー自体の長押しドラッグにも対応し、移動先をアニメーションで示してドロップ時に保存します。削除操作が変更するのは表示構成だけです。
構成は明示したJSONキーで保存してバックアップに含め、未知・他エディションのキーを保持します。開いているメニュー・編集対象・スクロール位置を再生成後に復元します。戻る・メニューボタンで開閉でき、アクセシビリティの移動操作も用意します。
検証: 関連Robolectricテスト4件成功。最新構成でAPI 35 ARM64/分離LiteアプリのUIテスト23件成功。実タッチのドラッグ、両モードの管理画面、追加・削除・共有保存、編集中の再生成、固定上部タブ、起動・遅延初期化・安全領域・検索を対象にしています。日本語の文字倍率1.0/1.3でも各5件成功しました。Full版UIと他のAndroidバージョンは未確認です。画像・検証ログはリポジトリ外に保存しています。
English
Share an editable side menu and bottom tabs across new and conventional settings. Conventional top tabs keep their fixed configuration.
Start the side menu with eight screens: Settings home, search, keyboard selection, appearance/position, learned dictionary, user dictionary, templates and custom keyboards. “Edit screens” offers clearly named “Side menu” and “Bottom tabs” sections for adding, removing and reordering destinations with fixed labels. Other settings categories are available to add.
Keep all five existing bottom defaults, with up to five pins and direct long-press drag/drop, animated slot previews and persistence on drop. Removing a shortcut only changes display configuration.
Use explicit JSON keys for stable persistence/backup and retain unknown/other-edition keys. Restore the open menu, editor section and scroll position after recreation. Support Back/menu toggling and accessibility move actions.
Validation: 4 related Robolectric tests passed. 23 UI tests passed against the latest scope on an isolated Lite app / API 35 ARM64. Coverage includes real touch drag/drop, management destinations in both modes, add/remove/shared persistence, editor recreation, fixed top tabs, startup/delayed initialization/safe areas and search. Five Japanese UI tests also passed at each font scale, 1.0 and 1.3. Full-edition UI and other Android versions remain untested. Images and logs stay outside the repository.