Repository navigation
両方の設定から折りたたみを廃止 / Use always-open headings in both settings - #1346
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
日本語
新規・従来の両設定でカテゴリの折りたたみを廃止し、常時表示の見出しに統一します。従来の上部タブは固定のままです。
保存済みの閉じた状態でも項目を隠さず、展開・折りたたみの案内文と矢印用レイアウトを削除します。検索・ハイライトからの既存呼び出しは設定値や条件付き表示を変えません。カテゴリの操作による項目の非表示処理が不要になるため、各項目自身の表示条件をそのまま使います。
検証: 関連ユニットテスト15件成功。API 35の分離Liteアプリで、両モードの常時表示、保存済み閉状態の無視、依存関係、値の保存、設定・ナビゲーションの画面テスト13件成功。まとめた実行では入力関連3件が失敗したため条件を確認し、Gboard英語レイアウトに揃えた検索・編集余白の4件を再実行して成功しました。最初の失敗を全体成功とは扱いません。Full版UI・他Androidバージョンは未確認です。
English
Remove collapsible settings categories from both new and conventional settings, using always-open headings. Conventional top tabs remain fixed.
Ignore previously saved collapsed states and remove the expand/collapse copy and arrow widget layout. Existing search/highlight calls do not change values or conditional visibility. Since category collapse no longer hides children, use each preference’s own visibility condition directly.
Validation: 15 related unit tests passed. On an isolated Lite app / API 35, 13 UI tests passed for both modes’ headings, saved collapsed states, dependencies, persistence, settings and navigation. Three input-related tests failed in the combined run; after inspecting conditions, the four search/editor-inset checks passed when rerun with Gboard’s English layout. The original combined run is not reported as a full pass. Full-edition UI and other Android versions remain untested.