Repository navigation
設定の再表示で分類別辞書が重複する不具合を修正 / Fix duplicate dictionary rows after Back navigation - #1355
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
分類別辞書から戻るたびに、辞書設定の入口と分類ごとの一括操作行が増えていました。従来の辞書タブ・新しい設定の両方で、1回の往復により入口が1→2件、一括操作行が28→56件になることを修正前のAPI35エミュレーターで再現しました。
AsyncPreferenceFragmentは設定階層を保持してビューだけを再作成します。その際に再実行される設定処理が、既存の行へ追加していました。入口と一括操作行をキーで再利用し、一括操作のコールバックと集計対象を再設定します。
検証:
端末テストはLite Debug、API35 arm64エミュレーター、日本語で実行。実機およびFull専用AI設定の端末確認は未実施です。アプリ全体の無不具合を保証するものではありません。
Returning from classified dictionaries appended another manager entry and another set of bulk-action rows. Before the fix, one round trip increased the entry count from 1 to 2 and bulk rows from 28 to 56 in both the legacy dictionary tab and the new settings route on an API35 emulator.
AsyncPreferenceFragment retains its preference hierarchy while recreating the view. The repeated setup appended new preferences to that hierarchy. Reuse rows by key and refresh the bulk-action callbacks and tracked categories.
Validation:
Device tests ran on Lite Debug, API35 arm64, Japanese locale. Physical devices and Full-only AI settings were not device-tested. This is a scoped regression audit, not a claim that the entire app is bug-free.