Repository navigation
Conversation
n7studios
marked this pull request as ready for review
November 13, 2026 01:21
n7studios
requested review from
a team,
ciccio-kit and
noelherrick
and removed request for
a team
November 13, 2026 01:21
noelherrick
approved these changes
Nov 13, 2026
| { | ||
| $emailTemplateID = $this->getStartingPointEmailTemplateID(); | ||
| if (!$emailTemplateID) { | ||
| $this->markTestSkipped('No Starting point email template exists on the Kit account.'); |
There was a problem hiding this comment.
I'm curious why you'd mark this as skipped - shouldn't we have a failure (with an assert that spells out exactly what needs to be done - add a starting place template to the test Kit account)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
allow_content_lossparameter toupdate_broadcast()andupdate_sequence_email()(changelog). Since 6 November 2026, changingemail_template_idwithoutcontentreturns a 409 when it would discard existing content; this parameter confirms the change.Testing
testUpdateBroadcastWithAllowContentLoss: Test changing a broadcast to a Starting point template without content returns an error, and succeeds withallow_content_loss.testUpdateSequenceEmailWithAllowContentLoss: Test the same for a sequence email.Checklist