Skip to content

Tests: Sync TestsTrait from PHP SDK - #134

Merged
n7studios merged 8 commits into
mainfrom
tests-filter-subscribers-pagination
Oct 29, 2026
Merged

n7studios merged 8 commits into
mainfrom
tests-filter-subscribers-pagination

Conversation

@n7studios

@n7studios n7studios commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Fixes integration tests that started failing because of changes to the Kit test account and API:

  • Syncs TestsTrait.php from the PHP SDK:
    • testFilterSubscribersPagination: the /v4/subscribers/filter endpoint now correctly returns has_previous_page: false and has_next_page: true when paginating back to the first page.
    • testGetSequencesPagination: no longer assumes the account has exactly 2 sequences. It now checks has_next_page against total_count.
  • ResourceTest: the testRefresh* tests no longer hard-code the first and last resource names, which broke when new tags were added to the account. A new assertResourcesSorted() helper checks that resources are in the order given by order_by and order, whatever resources exist on the account.

Testing

Existing tests pass.

Checklist

@n7studios n7studios self-assigned this Oct 27, 2026
@n7studios n7studios added the bug Something isn't working label Oct 27, 2026
@n7studios
n7studios requested review from a team, ciccio-kit and noelherrick and removed request for a team October 28, 2026 08:09
@n7studios n7studios added this to the 2.8.1 milestone Oct 28, 2026
@n7studios
n7studios merged commit f8ef417 into main Oct 29, 2026
0 of 13 checks passed
@n7studios
n7studios deleted the tests-filter-subscribers-pagination branch November 3, 2026 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants