Repository navigation
Fix ssl deprecate warn - #283
Merged
Merged
Conversation
auvipy
approved these changes
Jan 11, 2024
auvipy
left a comment
auvipy
left a comment
Collaborator
There was a problem hiding this comment.
is it possible to add / update relevant tests as well?
krishnan793
force-pushed
the
fix_ssl_deprecate_warn
branch
from
January 11, 2024 17:22
15a2d87 to
e57e07a
Compare
self signed certificate; no need to verify signed commit final commit
krishnan793
force-pushed
the
fix_ssl_deprecate_warn
branch
from
January 11, 2024 17:36
e57e07a to
1d9ffff
Compare
Contributor
Author
All the existing tests are passing. |
|
This needs to be released. It's not only deprecated, as of Python 3.12 the feature has been removed. |
|
@auvipy Hey! Can we by chance bump the version to release this change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ssl.wrap_socket() is deprecated from python 3.7 (see https://docs.python.org/3/library/ssl.html#ssl.SSLSocket). Based on documentation SSLContext.wrap_socket() should be used instead.