Repository navigation
[stage CI] 240 at 08490ff - #19
Closed
LeoBorcherding wants to merge 5 commits into
Closed
LeoBorcherding wants to merge 5 commits into
LeoBorcherding wants to merge 5 commits into
Conversation
MTP heads exported with nextn_shared_target_tensors carry no token_embd or output, which load_arch_tensors required, so mainline refused them. For such a head created as an MTP draft, take both from the target the draft context is created against. ctx_other itself stays unset: for draft-mtp it means the draft shares the target's memory, which this head does not. Any other use of such a head fails with a clear error rather than a null dereference. Heads converted before upstream MTP support also mark the MTP block dense (compress ratio 0). graph_mtp built the k-pool input regardless, but the draft's indexer cache then holds no layer, so the input was never allocated and the first decode asserted in set_input. Build it only for a QSA MTP block; build_layer_attn already treats ratio 0 as dense.
A shared MTP draft placed on other devices than the target (for example --spec-draft-device none or CUDA1) read token_embd/output from target buffers on devices its context had no backend for, and context creation aborted. Initialize a backend for every target device the draft context does not already have.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI staging copy of unslothai#240 at
08490ff69exactly (the author's branch head), based on its merge base withmaster,23b0202a1. Nothing is fixed here; review and fixes live on the mirror, #11.