Skip to content

feat: bundle Geist and demand-loaded vivo Sans SC interface fonts - #1235

Open
wibus-wee wants to merge 6 commits into
mainfrom
lody/04eaed2c-00e
Open

wibus-wee wants to merge 6 commits into
mainfrom
lody/04eaed2c-00e

Conversation

@wibus-wee

@wibus-wee wibus-wee commented Oct 3, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Default interface font: Geist + vivo Sans SC, retaining saved overrides, semantic text roles, optical sizing and monospace stacks.
  • Reproducible WOFF2 partitions from hash-pinned official archives: shipped Chinese UI, common Han, then on-demand tails. Preserve outlines, axes, names, hinting, copyright and complete licenses/Settings attribution. Assets are bundled locally; no runtime font CDN or committed font binaries/experiment screenshots.
  • Integrate main 9bdac2851da16cdf5bae2f22d811e721ccf58afb. Repair its existing Codex manifest/lock mismatch only: importer, necessary peer snapshots and exact-version release-age union. No ACP source or submodule pin changes; frozen installation stays mandatory.
  • Resolve complete-build preparation through existing selector/style leaf imports, eliminating two barrel cycles; use an Electron-resolvable relative font-notice import. No typography/layout redesign or compatibility layer.

Visual explanation

Official archives (build time only)
  -> verified recipe -> UI/common/tail unicode-range WOFF2 + original Geist
    -> hashed local assets -> shared default -> browser / Electron interface
  -> complete agreements -> bundled licenses + Settings attribution
Runtime: text selects packages; delay / failure / uncovered glyph -> native fallback

Final-head verification

Head: fa8f6fa95efe20f52214ca99ee7a443a452f7688.
Original implementation: 7533a4e2d526b320f715cf8571240ce0e941d646.

  • Passed on this head: pnpm install --frozen-lockfile, full OSS pnpm build, Storybook build, repository pnpm check with NODE_ENV=test NODE_OPTIONS=--no-experimental-webstorage, and formatting. The repository check covers types, lint, unit suites and public/platform boundaries.
  • Complete built Storybook runtime: all nine font/settings Chromium regressions passed (five tiers, light/dark, narrow viewport, portals, delays/failures and independent mono); two deterministic font checks passed. Isolated real Electron Appearance scenario passed all seven steps; Electron unit suite passed 199 tests.
  • Actual dense React scene, not frozen DOM: cold Geist/vivo three requests / 2,654,308 transferred bytes; all fonts four / 2,675,776 including existing code font. Warm reload transferred zero font bytes; rare text added one 318,716-byte tail. Initial CLS 0.02886 versus light before 0.02861.
  • Same rendered scene Chinese references: original TTF 44,430,472 bytes, single WOFF2 23,079,052, mechanical partitions 20,493,224 across nine requests. Full offline vivo partition payload is 23,627,116 bytes, not the first-screen figure.
  • CDP actual glyph evidence: Composer custom Geist 97 / custom vivo 47; mono remains separate. Uncovered 𠮷/𰻞 use native fallback. Failure readability passed, including 54 blocked font attempts rather than claiming zero requests.
  • Four final-head built-runtime before/after light/dark screenshots were uploaded as images in Lody; identical content, viewport, tool expansion, scroll and draft are recorded locally. No test agent tasks were sent. Earlier frozen DOM evidence remains transport-only, not runtime acceptance.
  • Devin independently reviewed the 7533a4e production diff, font script/tests and original light/dark screenshots and created this Draft PR. The follow-up lock/build fixes and final verification are reported by the implementation session for further review.

Remaining limits

  • Plain Node 26 reproduces the unchanged boot-shell experimental-storage failure (1/19 in the focused suite); disabling Node experimental webstorage makes the full repository check pass without changing product/tests. Local Node 22 cannot start due to a missing Homebrew simdutf library.
  • Pushing this head triggered fresh CI 37123300977 and Desktop E2E 37123300929. All seven CI jobs passed frozen installation; desktop installation is still in progress at handoff. The complete workflows are not reported as green based on local checks.
  • Docs check still has six existing links into uninitialized, root-excluded Kimi/Pi checkouts. This is not a pass. Old CI runs 37120580019/37120580017 failed frozen installation before application tests; their mismatch existed in baseline/main. They were not blindly rerun or relaxed.
  • vivo §2.2 forbids adaptation/secondary development and does not explicitly settle lossless transport conversion/subsetting. Preserve this interpretation uncertainty; no manufacturer written authorization is claimed.
  • Loopback macOS measurements do not establish Windows/Linux rendering, packaged installer distribution or real remote-network behavior. Sampled outline/axis checks are not exhaustive interpolation proofs.

See the owning notes and font module README for licenses and reproduction.

Keep this PR Draft for Devin review. Do not merge or deploy without Wibus's explicit approval.

@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Desktop PR regression failed on commit 7533a4e2d526b320f715cf8571240ce0e941d646.

Recordings not attached

  • Run evidence: failure-index.json is missing

The Actions artifact retains the complete trace, screenshots, logs, and runtime evidence.

@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Desktop PR regression failed on commit 780c10c553f7e8ba1a0c34d33dfca76fd0db922c.

Recordings not attached

  • Run evidence: failure-index.json is missing

The Actions artifact retains the complete trace, screenshots, logs, and runtime evidence.

Synchronize the baseline Codex lock importer without ACP source changes, preserve exact release-age approvals and platform binaries, and remove two existing UI barrel cycles blocking built Storybook validation.

Model: gpt-6.1-sol
@wibus-wee
wibus-wee marked this pull request as ready for review October 4, 2026 05:42
@wibus-wee

Copy link
Copy Markdown
Member Author

@copilot 解决此分支上的合并冲突。

Copilot AI and others added 2 commits October 4, 2026 05:43
Co-authored-by: wibus-wee <62133302+wibus-wee@users.noreply.github.com>
Co-authored-by: wibus-wee <62133302+wibus-wee@users.noreply.github.com>

Copilot AI commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

@copilot 解决此分支上的合并冲突。

已将 main 合并到此分支并解决冲突,保留双方测试与规格更新,并修复合并产生的重复 lockfile 项。提交:9f1c7cb。

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants