Repository navigation
fix(settings): name saved pi extensions by package before a scan - #1291
Merged
Merged
Conversation
Saved Pi extension selections persist only paths, so a reopened provider dialog showed every unscanned row by its file name, e.g. a column of index.ts. Derive the package (or folder) name from the path until a scan supplies the authoritative name. Model: claude-opus-5-5
timonwong
force-pushed
the
fix/pi-extension-saved-names
branch
from
October 7, 2026 08:10
d29c93b to
cb84eb1
Compare
timonwong
marked this pull request as ready for review
October 7, 2026 08:13
Lampese
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #1290
Problem / pressure
runtimeOverrides.piExtensionssaves only paths. When the Pi provider dialog is reopened, selected extensions that have not been scanned yet are named by their last path segment. Most npm-installed Pi extensions useindex.tsorindex.jsas their entry file, so the saved selection shows up as a column ofindex.tsuntil the user scans again.Summary
PiExtensionsField: an unscanned selected row is now named bysavedExtensionName(path):node_modules: the package name, including the scope (pi-smart-fetch,@ff-labs/pi-fff)index.*: the nearest parent folder, skippingsrc/dist/libVisual explanation
Simple change: one pure naming function used for unscanned rows in a single component; the call path does not change.
Before / after
~/.pi/agent/npm/node_modules/pi-smart-fetch/dist/index.jsindex.jspi-smart-fetch~/.pi/agent/npm/node_modules/@fradser/pi-vision/index.tsindex.ts@fradser/pi-vision~/.pi/agent/npm/node_modules/@ff-labs/pi-fff/src/index.tsindex.ts@ff-labs/pi-fffC:\…\ext\my-ext\index.tsindex.tsmy-ext/…/ext/single.tssingle.tssingle.tsTest plan
packages/components/tests/agent-config-dialog.test.tsx: opens an existing Pi provider that has the five saved paths above, without scanning, and checks the name and path shown in each row.index.*entry. In that case the file name is shown, as before.Context handoff
Original user prompt
Show original prompt
Sharing refusal (verbatim)
Shared conversation
Status: user-declined
Reason: The user chose not to publish the authoring conversation.