Add documentation for Hermes sampling profiler - #42
Merged
Merged
Conversation
jessieAnhNguyen
added
the
documentation
jessieAnhNguyen
marked this pull request as draft
August 18, 2020 03:52
jessieAnhNguyen
marked this pull request as ready for review
August 20, 2020 07:33
jessieAnhNguyen
requested review from
saphal1998
and removed request for
saphal1998
August 20, 2020 07:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR adds a new doc for Hermes sampling profiler. This is built as part of the goal to visualize the performance of JavaScript running on Hermes in a React Native app. @saphal1998 and I worked on this under @axemclion and @jevakallio guidance.
1. Purpose:
This new documentation
profile-hermes.mdinstructs the user on:The doc is added to the sidebar in the
Performancesession, right afterProfilingTest Plan: