Skip to content

Security Scan: stop flagging pinned hashes and test fixtures on release PRs #2225

Open

Description

@MODSetter

On the 2.2.0 release PR (#2214), Security Scan (detect-secrets, run 37994261254) failed on findings that are not secrets:

  • the sha256 pins in surfsense_local/backend/modules/runtime_packs/office/pin.py and a keyword in office/detect.py;
  • surfsense_local/electron/src/main/sidecars/python.test.ts and supervisor.test.ts;
  • the base64 fixtures in surfsense_local/frontend/src/features/docx-snapshot/fixtures/;
  • surfsense_backend/app/utils/proxy/providers/nodemaven.py:16.

None match the hook's excludes (.*/tests/.*, test_.*\.py), and the scan covers every file a release changes since main.

Done when: these are audited into .secrets.baseline or the excludes cover *.test.ts and fixtures/, so a release PR's scan shows only real findings.

Activity

  1. karthikeya1220 commented on Oct 14, 2026

    @karthikeya1220

    Hi! I'd like to work on this issue. I'll reproduce the false positives from the release security scan, inspect the existing detect-secrets configuration, and make the smallest safe change to .secrets.baseline or the exclusion rules. I'll verify that legitimate secret detection remains enabled and run the relevant checks locally without any paid services.

    @MODSetter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions