Skip to content

[LLM|Models] Ship the local model manifest in the Studio worker - #1910

Merged
CREDO23 merged 1 commit into
MODSetter:devfrom
CREDO23:fix/worker-local-manifest
Sep 24, 2026
Merged

CREDO23 merged 1 commit into
MODSetter:devfrom
CREDO23:fix/worker-local-manifest

Conversation

@CREDO23

@CREDO23 CREDO23 commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • The packaged Studio worker now ships the local model manifest. Without it, the worker's local catalog fell back to an empty list, so an installed, selected image model failed within seconds with "the local image model is not installed". This was found in a packaged-app smoke test with SD 1.5. Podcasts find their audio model the same way.
  • test_spec_data_files.py now checks each binary that reads the manifest (api.spec and worker.spec), not just any one of them; the API's copy was hiding the worker's gap. Its paths are now forward-slash on every platform, which fixes its known Windows failure.
  • test_real_binaries.py checks that the frozen worker's bundle contains the file. Frozen locally: it fails without the fix and passes with it.

Follows #1903, which moved image models onto the local manifest.

🤖 Generated with Claude Code

The frozen worker bundled only the remote manifest, so its local catalog
fell back to an empty list and an installed, chosen image model failed
with "the local image model is not installed". Podcasts resolve their
audio model the same way.

The spec test now checks each binary that reads the manifest, not any
one, and returns forward-slash paths, which also fixes its Windows run.
The frozen worker test checks the file is in the bundle.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Sep 24, 2026

Copy link
Copy Markdown

@CREDO23 is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Sep 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: c8ed1637-6ad5-4605-9897-9aae6f5fed8f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@CREDO23
CREDO23 merged commit a339fe9 into MODSetter:dev Sep 24, 2026
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant