Repository navigation
docs(proposals): run the desktop stack in Docker, with CPU and CUDA images - #2098
Merged
Merged
Conversation
…mages The desktop app's stack, without Electron, ships as one container in docker/local/: a supervisor shared with Electron runs the API, the workers and the model servers on loopback, and Caddy is the only listener. Without a password it answers only localhost; with one it uses basic auth, over HTTPS when a domain is set. Images come as CPU, -cuda (12.8) and -cuda126 (12.6) on amd64 and arm64. The license is the desktop's offline file. The legacy stack in docker/ is not changed. ADR 0035 records the decision and supersedes parts of ADR 0004 (Docker out of scope, the loopback rule) and ADR 0012 (no CUDA), for Docker only.
|
@AnishSarkar22 is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: MODSetter/SurfSense/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
docs/proposals/docker/README.md: the desktop app's stack, without Electron, as one container indocker/local/:/datavolume./api, and refuses/api/internal/*.localhost. WithSURFSENSE_PASSWORD, it uses basic auth, over HTTPS when a domain is set.docs/proposals/docker/gpu.md:-cuda(12.8) and-cuda126(12.6), on amd64 and arm64, named as the legacy backend's are.SURFSENSE_ALLOW_CPU=1.docker/folder changes.Why
surfsense-backend,surfsense-web) and their compose stack.surfsense_backendisn't affected.Fixes #
How to test
python scripts/check_docs.pyHostcheck as the guard when no password is set;-cuda126;High-level PR Summary
This PR proposes running the desktop app's stack in Docker as a single container, replacing the legacy multi-service self-host architecture. The proposal introduces CPU and CUDA image variants (
-cudaand-cuda126) that run the API, workers, and model servers via a shared supervisor, with Caddy as the only listener handling authentication and reverse proxying. The decision is recorded in ADR 0035, which partially supersedes ADRs 0004 and 0012 for Docker deployments. This is documentation only—no code changes are included, and the legacydocker/folder remains untouched.⏱️ Estimated Review Time: 5-15 minutes
💡 Review Order Suggestion
docs/adr/0035-docker-compose-runs-the-desktop-stack.mddocs/proposals/docker/README.mddocs/proposals/docker/gpu.mddocs/adr/0004-desktop-app-is-its-own-tree.mddocs/adr/0012-vulkan-only-gpu-backend.mddocs/adr/README.md