Repository navigation
feat(local): move resource usage into Settings › Resources - #2130
Merged
Merged
Conversation
The Resources panel leaves the top of the right column, which is back to Studio alone, and becomes its own settings section between Video and Network. It polls only while that section is open, since the dialog mounts just the open section. The section is laid out like the other settings pages, with no card. It has three headed parts with separators between them: This computer for the bars and legend, By engine for the per-engine table, and Graphics, which names each card with its memory or says it shares the CPU's. With more than one card, Graphics numbers them like the GPU rows so a name matches its bars. The per-engine table is always shown, so the chevron and its localStorage preference are gone. Every settings section now scrolls its heading with its content, so General, Network, License and Resources match the model pages and About.
|
@AnishSarkar22 is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: MODSetter/SurfSense/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (29)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Resources panel leaves the top of the right column, which is back to Studio alone, and becomes its own settings section between Video and Network. It polls only while that section is open, since the dialog mounts just the open section.
The section is laid out like the other settings pages, with no card. It has three headed parts with separators between them: This computer for the bars and legend, By engine for the per-engine table, and Graphics, which names each card with its memory or says it shares the CPU's. With more than one card, Graphics numbers them like the GPU rows so a name matches its bars. The per-engine table is always shown, so the chevron and its localStorage preference are gone.
Every settings section now scrolls its heading with its content, so General, Network, License and Resources match the model pages and About.
Why
Fixes #
How to test
High-level PR Summary
This PR reorganizes the resource usage interface by moving it from a standalone panel in the right column to its own settings section called Resources, positioned between Video and Network. The new settings section has three parts: This computer showing overall machine metrics with bars, By engine with a table of per-engine resource consumption, and Graphics listing graphics cards with their memory details. The section is now laid out like other settings pages without a card wrapper, and resource polling occurs only while the Resources section is open. Additionally, all settings sections now scroll their headings with their content for visual consistency.
⏱️ Estimated Review Time: 30-90 minutes
💡 Review Order Suggestion
docs/architecture/overview.mddocs/architecture/resource-usage.mdsurfsense_local/frontend/src/features/resources/resource-settings.tsxsurfsense_local/frontend/src/features/resources/live-resource-usage.tsxsurfsense_local/frontend/src/features/resources/use-resource-usage.tssurfsense_local/frontend/src/features/resources/resource-usage-panel.tsxsurfsense_local/frontend/src/features/resources/usage-section.tsxsurfsense_local/frontend/src/features/resources/graphics-cards.tsxsurfsense_local/frontend/src/features/resources/engine-breakdown.tsxsurfsense_local/frontend/src/features/resources/usage-meter.tsxsurfsense_local/frontend/src/features/resources/breakdown-pref.tssurfsense_local/frontend/src/features/dashboard/right-panel.tsxsurfsense_local/frontend/src/features/dashboard/dashboard-page.tsxsurfsense_local/frontend/src/features/settings/settings-dialog.tsxsurfsense_local/frontend/src/features/settings/settings-section.tsxsurfsense_local/frontend/src/features/resources/live-resource-usage.test.tsxsurfsense_local/frontend/src/features/resources/resource-usage-panel.test.tsxsurfsense_local/frontend/src/features/settings/settings-dialog.test.tsxsurfsense_local/frontend/src/features/resources/usage-rows.tssurfsense_local/frontend/translations/en.jsonsurfsense_local/frontend/translations/de.jsonsurfsense_local/frontend/translations/es.jsonsurfsense_local/frontend/translations/fr.jsonsurfsense_local/frontend/translations/hi.jsonsurfsense_local/frontend/translations/ja.jsonsurfsense_local/frontend/translations/ko.jsonsurfsense_local/frontend/translations/pt-BR.jsonsurfsense_local/frontend/translations/ru.jsonsurfsense_local/frontend/translations/zh-CN.json